Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(g-canvas): arrow support bbox calculation and hit #443

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Conversation

dengfuping
Copy link
Member

@dengfuping dengfuping commented Mar 12, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 箭头的包围盒最后决定还是放 bbox 了,毕竟也是图形的一部分。

📝 Changelog

Language Changelog
🇺🇸 English 🌟 [g-canvas] Arrow support for bbox calculation and hit. #432
🇨🇳 Chinese 🌟 [g-canvas] 箭头支持包围盒计算和拾取。#432

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 12, 2020

This pull request introduces 3 alerts and fixes 1 when merging 90ab955 into 8bd9913 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@dengfuping dengfuping requested a review from dxq613 March 12, 2020 14:53
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 12, 2020

This pull request introduces 3 alerts and fixes 1 when merging 74eae2f into 8bd9913 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@dxq613 dxq613 merged commit aabbc8d into master Mar 13, 2020
@dxq613 dxq613 deleted the fix-issue-432 branch March 13, 2020 13:46
@pr-triage pr-triage bot added the PR: merged label Mar 13, 2020
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
feat(g-canvas): arrow support bbox calculation and hit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants