Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(refresh): fixed bug #444 #445

Merged
merged 1 commit into from
Mar 18, 2020
Merged

fix(refresh): fixed bug #444 #445

merged 1 commit into from
Mar 18, 2020

Conversation

dxq613
Copy link
Member

@dxq613 dxq613 commented Mar 18, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
  • 部分用户经常会缩放浏览器，导致 pixelRatio 不是整数，在 1-2 之间时，图形刷新时会有残影，原因在于浏览器无法绘制非整数像素，都会多扩展出像素，目前在最终的包围盒外侧，各增加 0.5 个像素，这时候再取整，就会将超出的部分涵盖进来。

@dxq613 dxq613 requested a review from dengfuping March 18, 2020 06:30
@auto-add-label auto-add-label bot added the bug label Mar 18, 2020
tests-checker[bot]
tests-checker bot suggested changes Mar 18, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@dengfuping dengfuping merged commit 4c7760e into master Mar 18, 2020
@dengfuping dengfuping deleted the pixel_refresh branch March 18, 2020 08:50
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
@dengfuping
Merge pull request antvis#445 from antvis/pixel_refresh
c9c6567 
fix(refresh): fixed bug antvis#444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@dengfuping dengfuping dengfuping approved these changes

Assignees
No one assigned
Labels
bug PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dxq613 @dengfuping