Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 添加空判断，防止报错 #470

Merged
merged 1 commit into from
Apr 9, 2020
Merged

fix: 添加空判断，防止报错 #470

merged 1 commit into from
Apr 9, 2020

Conversation

simaQ
Copy link
Contributor

@simaQ simaQ commented Apr 9, 2020

在 G2，当传入空数据进行绘制图表后，鼠标在图表上移动会报错。

@simaQ simaQ requested a review from dengfuping April 9, 2020 07:43
@auto-add-label auto-add-label bot added the bug label Apr 9, 2020
tests-checker[bot]
tests-checker bot suggested changes Apr 9, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@dengfuping
Copy link
Member

  • CI 失败是由于其中 image 的单测不稳定导致，不影响合并。

@dengfuping dengfuping merged commit 8c25745 into master Apr 9, 2020
@dengfuping dengfuping deleted the daily-fix branch April 9, 2020 09:47
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
@dengfuping
Merge pull request antvis#470 from antvis/daily-fix
ee4749a 
fix: 添加空判断，防止报错
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@dengfuping dengfuping dengfuping approved these changes

Assignees
No one assigned
Labels
bug PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simaQ @dengfuping