fix: 修复极大数量求最大值、最小值出错

packages/g-base/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-base",
-  "version": "0.5.5",
+  "version": "0.5.6",
   "description": "A common util collection for antv projects",
   "main": "lib/index.js",
   "module": "esm/index.js",

packages/g-base/src/abstract/container.ts

@@ -1,3 +1,4 @@
+import { max, min } from '@antv/util';
 import { IContainer, IShape, IGroup, IElement, ICanvas } from '../interfaces';
 import { BBox, ElementFilterFn } from '../types';
 import Timeline from '../animate/timeline';
@@ -89,10 +90,10 @@ abstract class Container extends Element implements IContainer {
         xArr.push(box.minX, box.maxX);
         yArr.push(box.minY, box.maxY);
       });
-      minX = Math.min.apply(null, xArr);
-      maxX = Math.max.apply(null, xArr);
-      minY = Math.min.apply(null, yArr);
-      maxY = Math.max.apply(null, yArr);
+      minX = min(xArr);
+      maxX = max(xArr);
+      minY = min(yArr);
+      maxY = max(yArr);
     } else {
       minX = 0;
       maxX = 0;
@@ -131,10 +132,10 @@ abstract class Container extends Element implements IContainer {
         xArr.push(box.minX, box.maxX);
         yArr.push(box.minY, box.maxY);
       });
-      minX = Math.min.apply(null, xArr);
-      maxX = Math.max.apply(null, xArr);
-      minY = Math.min.apply(null, yArr);
-      maxY = Math.max.apply(null, yArr);
+      minX = min(xArr);
+      maxX = max(xArr);
+      minY = min(yArr);
+      maxY = max(yArr);
     } else {
       minX = 0;
       maxX = 0;

packages/g-base/src/bbox/path.ts

@@ -1,6 +1,6 @@
 import { Quad as QuadUtil, Cubic as CubicUtil, Arc as EllipseArcUtil } from '@antv/g-math';
 import { path2Segments } from '@antv/path-util';
-import { isNumberEqual } from '@antv/util';
+import { isNumberEqual, max, min } from '@antv/util';
 import { SimpleBBox } from '../types';
 import { IShape } from '../interfaces';
 import { mergeArrowBBox } from './util';
@@ -50,10 +50,10 @@ function getPathBox(segments, lineWidth) {
   // ref: https://github.com/antvis/g/issues/210
   xArr = xArr.filter((item) => !Number.isNaN(item));
   yArr = yArr.filter((item) => !Number.isNaN(item));
-  let minX = Math.min.apply(null, xArr);
-  let minY = Math.min.apply(null, yArr);
-  let maxX = Math.max.apply(null, xArr);
-  let maxY = Math.max.apply(null, yArr);
+  let minX = min(xArr);
+  let minY = min(yArr);
+  let maxX = max(xArr);
+  let maxY = max(yArr);
   if (segmentsWithAngle.length === 0) {
     return {
       x: minX,

packages/g-base/src/index.ts

@@ -20,4 +20,4 @@ export { isAllowCapture } from './util/util';
 export { multiplyVec2, invert } from './util/matrix';
 export { getOffScreenContext } from './util/offscreen';
 
-export const version = '0.5.5';
+export const version = '0.5.6';

packages/g-canvas/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-canvas",
-  "version": "0.5.6",
+  "version": "0.5.7",
   "description": "A canvas library which providing 2d",
   "main": "lib/index.js",
   "module": "esm/index.js",

packages/g-canvas/src/group.ts

@@ -5,7 +5,7 @@ import { Region } from './types';
 import ShapeBase from './shape/base';
 import * as Shape from './shape';
 import { applyAttrsToContext, drawChildren, refreshElement } from './util/draw';
-import { each } from '@antv/util';
+import { each, max, min } from '@antv/util';
 import { intersectRect } from './util/util';
 
 class Group extends AbstractGroup {
@@ -57,10 +57,10 @@ class Group extends AbstractGroup {
     });
     let bbox = null;
     if (xArr.length) {
-      const minX = Math.min.apply(null, xArr);
-      const maxX = Math.max.apply(null, xArr);
-      const minY = Math.min.apply(null, yArr);
-      const maxY = Math.max.apply(null, yArr);
+      const minX = min(xArr);
+      const maxX = max(xArr);
+      const minY = min(yArr);
+      const maxY = max(yArr);
       bbox = {
         minX,
         minY,

packages/g-canvas/src/index.ts

@@ -7,4 +7,4 @@ export { default as Group } from './group';
 export { Shape };
 export { default as getArcParams } from './util/arc-params';
 
-export const version = '0.5.6';
+export const version = '0.5.7';

packages/g-canvas/src/util/draw.ts

@@ -1,5 +1,5 @@
-import { each, isArray } from '@antv/util';
-import { IElement, IGroup } from '../interfaces';
+import { each, isArray, max, min } from '@antv/util';
+import { IElement } from '../interfaces';
 import { Region } from '../types';
 import { parseStyle } from './parse';
 import getArcParams from './arc-params';
@@ -265,7 +265,7 @@ export function refreshElement(element, changeType) {
   }
 }
 
-export function getRefreshRegion(element) {
+export function getRefreshRegion(element): Region | undefined {
   let region;
   if (!element.destroyed) {
     const cacheBox = element.get('cacheCanvasBBox');
@@ -305,10 +305,10 @@ export function getMergedRegion(elements): Region {
     }
   });
   return {
-    minX: Math.min.apply(null, minXArr),
-    minY: Math.min.apply(null, minYArr),
-    maxX: Math.max.apply(null, maxXArr),
-    maxY: Math.max.apply(null, maxYArr),
+    minX: min(minXArr),
+    minY: min(minYArr),
+    maxX: max(maxXArr),
+    maxY: max(maxYArr),
   };
 }
 

packages/g-math/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-math",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "description": "geometry math",
   "main": "lib/index.js",
   "module": "esm/index.js",

packages/g-math/src/util.ts

@@ -1,13 +1,6 @@
+import { max, min } from '@antv/util';
 import { BBox } from './types';
 
-function minNum(array: number[]) {
-  return Math.min.apply(null, array);
-}
-
-function maxNum(array: number[]) {
-  return Math.max.apply(null, array);
-}
-
 /**
  * 两点之间的距离
  * @param {number} x1 起始点 x
@@ -27,10 +20,10 @@ export function isNumberEqual(v1: number, v2: number) {
 }
 
 export function getBBoxByArray(xArr: number[], yArr: number[]): BBox {
-  const minX = minNum(xArr);
-  const minY = minNum(yArr);
-  const maxX = maxNum(xArr);
-  const maxY = maxNum(yArr);
+  const minX = min(xArr);
+  const minY = min(yArr);
+  const maxX = max(xArr);
+  const maxY = max(yArr);
   return {
     x: minX,
     y: minY,
@@ -41,10 +34,10 @@ export function getBBoxByArray(xArr: number[], yArr: number[]): BBox {
 
 export function getBBoxRange(x1: number, y1: number, x2: number, y2: number) {
   return {
-    minX: minNum([x1, x2]),
-    maxX: maxNum([x1, x2]),
-    minY: minNum([y1, y2]),
-    maxY: maxNum([y1, y2]),
+    minX: min([x1, x2]),
+    maxX: max([x1, x2]),
+    minY: min([y1, y2]),
+    maxY: max([y1, y2]),
   };
 }