Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复数据为 0 时动画更新出错 #3378

Merged
merged 2 commits into from
Apr 16, 2021
Merged

fix: 修复数据为 0 时动画更新出错 #3378

merged 2 commits into from
Apr 16, 2021

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Apr 16, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

饼图存在空数据时 sector-path-update 会导致动画超出画布。

before after

|

@lxfu1
Copy link
Member Author

lxfu1 commented Apr 16, 2021

@lxfu1
Copy link
Member Author

lxfu1 commented Apr 16, 2021

hustcc
hustcc previously approved these changes Apr 16, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 754544481

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 93.575%

Totals Coverage Status
Change from base Build 743742278: 0.07%
Covered Lines: 10926
Relevant Lines: 11324

💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Apr 16, 2021

原来饼图的过度动画出问题是这里除了问题!能 blame 到之前是怎么碰伤的吗?

@hustcc hustcc self-requested a review April 16, 2021 06:37
@hustcc hustcc merged commit e132a30 into master Apr 16, 2021
@hustcc hustcc deleted the fix/574 branch April 16, 2021 06:38
joriewong added a commit to joriewong/g2 that referenced this pull request Apr 20, 2021
fix: 修复数据为 0 时动画更新出错 (antvis#3378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants