Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site): disable css parsing #5091

Merged
merged 1 commit into from
May 25, 2023
Merged

fix(site): disable css parsing #5091

merged 1 commit into from
May 25, 2023

Conversation

pearmini
Copy link
Member

CSS Parsing

在 G2 代码里禁用 G 的 CSS Parsing 的能力。

存在问题

之前是在 GUI 里面禁用的,但是官网不知道设置失效(可能和打包顺序有关系),导致官网报错:

image

解决办法

G2 的 index.ts 中显示指定为 false,这个 PR 合并之后需要重新部署官网。

@pearmini pearmini merged commit c21787f into v5 May 25, 2023
@pearmini pearmini deleted the fix/disable-css-parsing branch May 25, 2023 07:13
@pearmini
Copy link
Member Author

pearmini commented May 25, 2023

经过排查应该是这个 PR:antvis/GUI#287 带来的问题,因为表明了 sideEffects 为 false,所以 GUI 禁用 CSS 解析的代码应该没有被打包进去。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants