Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static-mark): add axisX and axisY #5188

Merged
merged 2 commits into from
Jun 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
46 changes: 46 additions & 0 deletions __tests__/plots/static/alphabet-interval-axis.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import { G2Spec } from '../../../src';

export function alphabetIntervalAxis(): G2Spec {
return {
type: 'view',
padding: 'auto',
children: [
{
type: 'interval',
transform: [{ type: 'sortX', by: 'y', reverse: true }],
data: {
type: 'fetch',
value: 'data/alphabet.csv',
},
encode: {
x: 'letter',
y: 'frequency',
color: 'steelblue',
},
axis: { y: { tickCount: 10 }, x: false },
},
{ type: 'axisX', title: 'Letter', style: { labelFontSize: 20 } },
{
type: 'axisY',
labelFormatter: '.0%',
title: 'Frequency',
scale: { y: { nice: true } },
},
{
type: 'axisY',
position: 'right',
scale: {
y: {
type: 'linear',
independent: true,
domain: [0, 10],
range: [1, 0],
},
},
style: {
grid: false,
},
},
],
};
}
5 changes: 5 additions & 0 deletions __tests__/plots/static/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,3 +242,8 @@ export { vennBasic } from './venn-basic';
export { vennHollow } from './venn-hollow';
export { stocksLineVarSize } from './stocks-line-var-size';
export { barleyLineTrail } from './barley-line-trail';
export { mockAxisX } from './mock-axisX';
export { mockAxisY } from './mock-axisY';
export { mockAxisXY } from './mock-axisXY';
export { mockAxisXYPolar } from './mock-axisXY-polar';
export { alphabetIntervalAxis } from './alphabet-interval-axis';
17 changes: 17 additions & 0 deletions __tests__/plots/static/mock-axisX.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { G2Spec } from '../../../src';

export function mockAxisX(): G2Spec {
return {
type: 'axisX',
padding: 'auto',
height: 80,
scale: {
x: {
type: 'linear',
domain: [5, 10],
range: [0, 1],
},
},
tickCount: 10,
};
}
37 changes: 37 additions & 0 deletions __tests__/plots/static/mock-axisXY-polar.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { G2Spec } from '../../../src';

export function mockAxisXYPolar(): G2Spec {
return {
type: 'view',
padding: 'auto',
coordinate: { type: 'polar' },
scale: {
x: {
type: 'linear',
domain: [5, 10],
range: [0, 1],
},
y: {
type: 'linear',
domain: [5, 10],
range: [0, 1],
},
},
children: [
{
type: 'axisX',
title: 'AxisX',
tickFilter: (_, i, ticks) => i && i !== ticks.length - 1,
},
{
type: 'axisY',
title: 'AxisY',
style: {
labelFontSize: 14,
gridLineWidth: 10,
gridStroke: 'red',
},
},
],
};
}
33 changes: 33 additions & 0 deletions __tests__/plots/static/mock-axisXY.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { G2Spec } from '../../../src';

export function mockAxisXY(): G2Spec {
return {
type: 'view',
padding: 'auto',
scale: {
x: {
type: 'linear',
domain: [5, 10],
range: [0, 1],
},
y: {
type: 'linear',
domain: [5, 10],
range: [0, 1],
},
},
children: [
{ type: 'axisX', title: 'AxisX' },
{
type: 'axisY',
title: 'AxisY',
tickCount: 10,
style: {
labelFontSize: 14,
gridLineWidth: 10,
gridStroke: 'red',
},
},
],
};
}
24 changes: 24 additions & 0 deletions __tests__/plots/static/mock-axisY.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { G2Spec } from '../../../src';

export function mockAxisY(): G2Spec {
return {
type: 'axisY',
padding: 10,
paddingLeft: 'auto',
width: 100,
scale: {
y: {
type: 'linear',
domain: [5, 10],
range: [0, 1],
},
},
tickCount: 10,
title: 'axisX',
style: {
labelFontSize: 14,
gridLineWidth: 10,
gridStroke: 'red',
},
};
}
6 changes: 6 additions & 0 deletions __tests__/unit/api/chart.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ import {
Gauge,
Density,
Heatmap,
AxisX,
AxisY,
} from '../../../src/api/mark/mark';

const TEST_OPTIONS = {
Expand Down Expand Up @@ -166,6 +168,8 @@ describe('Chart', () => {
expect(chart.gauge()).toBeInstanceOf(Gauge);
expect(chart.density()).toBeInstanceOf(Density);
expect(chart.heatmap()).toBeInstanceOf(Heatmap);
expect(chart.axisX()).toBeInstanceOf(AxisX);
expect(chart.axisY()).toBeInstanceOf(AxisY);
expect(chart.options().children).toEqual([
{ type: 'interval' },
{ type: 'rect' },
Expand Down Expand Up @@ -196,6 +200,8 @@ describe('Chart', () => {
{ type: 'gauge' },
{ type: 'density' },
{ type: 'heatmap' },
{ type: 'axisX' },
{ type: 'axisY' },
]);
});

Expand Down
33 changes: 33 additions & 0 deletions __tests__/unit/api/mark.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import {
Tree,
WordCloud,
Gauge,
AxisX,
AxisY,
} from '../../../src/api/mark/mark';

type Mark =
Expand Down Expand Up @@ -161,6 +163,25 @@ function getLayoutOptions() {
};
}

function setAxisOptions(node: AxisX | AxisY): AxisX | AxisY {
return node
.scale('x', { type: 'linear' })
.transform({ type: 'hide' })
.style('gridFill', 'red')
.state('active', { gridFill: 'red' })
.attr('labelFormatter', '~s');
}

function getAxisOptions() {
return {
scale: { x: { type: 'linear' } },
transform: [{ type: 'hide' }],
style: { gridFill: 'red' },
state: { active: { gridFill: 'red' } },
labelFormatter: '~s',
};
}

describe('mark.get[Instance]()', () => {
let view;
let interval;
Expand Down Expand Up @@ -376,4 +397,16 @@ describe('mark.[node]()', () => {
expect(node.type).toBe('gauge');
expect(setCompositeOptions(node).value).toEqual(getOptions());
});

it('AxisX() should specify options by API', () => {
const node = new AxisX();
expect(node.type).toBe('axisX');
expect(setAxisOptions(node).value).toEqual(getAxisOptions());
});

it('AxisY() should specify options by API', () => {
const node = new AxisY();
expect(node.type).toBe('axisY');
expect(setAxisOptions(node).value).toEqual(getAxisOptions());
});
});
31 changes: 31 additions & 0 deletions site/examples/component/axis/demo/axis-multi.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { Chart } from '@antv/g2';

const chart = new Chart({
container: 'container',
theme: 'classic',
autoFit: true,
});

chart
.interval()
.data({
type: 'fetch',
value:
'https://gw.alipayobjects.com/os/bmw-prod/fb9db6b7-23a5-4c23-bbef-c54a55fee580.csv',
})
.encode('x', 'letter')
.encode('y', 'frequency')
.axis('y', { labelFormatter: '.0%' });

chart
.axisY()
.attr('position', 'right')
.scale('y', {
type: 'linear',
independent: true,
domain: [0, 10],
range: [1, 0],
})
.style('grid', false);

chart.render();
34 changes: 34 additions & 0 deletions site/examples/component/axis/demo/axis-polar.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { Chart } from '@antv/g2';

const chart = new Chart({
container: 'container',
theme: 'classic',
padding: 'auto',
});

chart
.coordinate({ type: 'polar' })
.scale('x', {
type: 'linear',
domain: [5, 10],
range: [0, 1],
})
.scale('y', {
type: 'linear',
domain: [5, 10],
range: [1, 0],
});

chart
.axisX()
.attr('title', 'AxisX')
.attr('tickFilter', (_, i, ticks) => i && i !== ticks.length - 1);

chart
.axisY()
.attr('title', 'AxisY')
.style('labelFontSize', 14)
.style('gridLineWidth', 10)
.style('gridStroke', 'red');

chart.render();
20 changes: 20 additions & 0 deletions site/examples/component/axis/demo/axis-x.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { Chart } from '@antv/g2';

const chart = new Chart({
container: 'container',
theme: 'classic',
padding: 'auto',
height: 80,
});

chart
.axisX()
.scale('x', {
type: 'linear',
domain: [5, 10],
range: [0, 1],
})
.attr('tickCount', 10)
.attr('title', 'AxisX');

chart.render();
31 changes: 31 additions & 0 deletions site/examples/component/axis/demo/axis-xy.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { Chart } from '@antv/g2';

const chart = new Chart({
container: 'container',
theme: 'classic',
padding: 'auto',
});

chart
.scale('x', {
type: 'linear',
domain: [5, 10],
range: [0, 1],
})
.scale('y', {
type: 'linear',
domain: [5, 10],
range: [0, 1],
});

chart.axisX().attr('title', 'AxisX');

chart
.axisY()
.attr('title', 'AxisY')
.attr('tickCount', 10)
.style('labelFontSize', 14)
.style('gridLineWidth', 10)
.style('gridStroke', 'red');

chart.render();
Loading