Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update component click event #5440

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Conversation

BinghuiXie
Copy link
Contributor

Checklist
  • npm test passes
  • commit message follows commit guidelines
  • documents are updated
Description of change

增加 component 的全局监听事件,之前点击图例和坐标轴,通过 chart.on('component:click') 监听不到点击事件

@pearmini pearmini self-requested a review August 21, 2023 13:33
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很棒,不过这里还需要添加一个测试就完美了,可以参考这个文件:__tests__/integration/api-chart-on-text-click.spec.ts

@pearmini
Copy link
Member

pearmini commented Aug 21, 2023

还有一点就是,目前 G2 有国际化的目标,所以 commit 描述和 pr 的标题都尽量用英文!

@BinghuiXie BinghuiXie changed the title 更新组件监听事件 update component click event Aug 22, 2023
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@pearmini pearmini merged commit 01ab11a into antvis:v5 Aug 23, 2023
1 check passed
pearmini added a commit that referenced this pull request Aug 23, 2023
pearmini added a commit that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants