Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): support node with callback children #5594

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Sep 25, 2023

chart.options({
  type: 'repeatMatrix',
  width: 480,
  height: 480,
  paddingLeft: 50,
  paddingBottom: 50,
  data: {
    type: 'fetch',
    value: 'data/penguins.csv',
  },
  encode: {
    position: ['culmen_length_mm', 'culmen_depth_mm'],
    color: 'species', // 需要显式指定颜色编码,否则无法推断
  },
  children: () => ({ // 回调
    type: 'point',
    encode: { color: 'species' },
  }),
});

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6297209889

  • 17 of 18 (94.44%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 88.193%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/api/utils.ts 17 18 94.44%
Totals Coverage Status
Change from base Build 6296221511: 0.009%
Covered Lines: 10029
Relevant Lines: 11013

💛 - Coveralls

@pearmini pearmini merged commit d916851 into v5 Sep 25, 2023
@pearmini pearmini deleted the feat/callback-children branch September 25, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants