Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add the two axis charts demo #5740

Merged
merged 5 commits into from
Nov 6, 2023
Merged

docs: add the two axis charts demo #5740

merged 5 commits into from
Nov 6, 2023

Conversation

Runtus
Copy link
Contributor

@Runtus Runtus commented Nov 6, 2023

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把 two-axis 改成 dual-axes 会好一点?

@Runtus
Copy link
Contributor Author

Runtus commented Nov 6, 2023

哦哦好的,确实要好一些,应该和类型的title统一下,我马上改一改

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pearmini pearmini merged commit 514adaf into antvis:v5 Nov 6, 2023
2 checks passed
@pearmini pearmini mentioned this pull request Nov 6, 2023
1 task
Exlau pushed a commit to Exlau/G2 that referenced this pull request Nov 10, 2023
* feat: add two-axis-chart demos and finish code

* feat: add demo info in meta.json

* feat: add screenshot link to meta.json and format code style

* fix: fix the chart title in meta.json

* fix: change the chart name in English
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants