Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Spec-Scale): Translate Spec-Scale to En #5764

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Conversation

owenchen1004
Copy link
Contributor

@owenchen1004 owenchen1004 commented Nov 8, 2023

Issue: #5743

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6793311950

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.241%

Totals Coverage Status
Change from base Build 6784548527: 0.0%
Covered Lines: 10021
Relevant Lines: 10992

💛 - Coveralls

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

有几个小问题需要注意一下!

site/docs/manual/core/api.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/api.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/api.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/api.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/api.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/mark.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/scale.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/scale.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/scale.en.md Outdated Show resolved Hide resolved
site/docs/manual/core/scale.en.md Outdated Show resolved Hide resolved
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还剩下一个小问题

site/docs/manual/core/scale.en.md Show resolved Hide resolved
@pearmini
Copy link
Member

@owenchen1004 这个 PR 我先合并了,上面的问题你单独开一个 PR 修复即可。

@pearmini pearmini closed this Nov 10, 2023
@pearmini pearmini reopened this Nov 10, 2023
@pearmini pearmini merged commit 7288688 into antvis:v5 Nov 10, 2023
3 of 4 checks passed
@pearmini pearmini mentioned this pull request Nov 10, 2023
1 task
@owenchen1004 owenchen1004 mentioned this pull request Nov 13, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants