Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ci issues #5839

Merged
merged 8 commits into from
Nov 27, 2023
Merged

Fix ci issues #5839

merged 8 commits into from
Nov 27, 2023

Conversation

thejasonxie
Copy link

Checklist
  • npm test passes
  • commit message follows commit guidelines
Description of change

My previous PR had ci issues. Still new to contributing, so didn't realize tests not related to my prev commits had to be fixed as well.

Fixed following ci issues:

  • style linting - 4 files weren't following correct style format
  • test - fixed chart show and hide test failure
  • test - github actions requires more time for animation to complete before testing

pearmini
pearmini requested changes Nov 24, 2023
View reviewed changes
src/chart/chart.ts Outdated Show resolved Hide resolved
@pearmini pearmini merged commit 81a10f8 into antvis:v4.1.x Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thejasonxie @pearmini