Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

优化mark area的smooth的曲线绘制策略 #5877

Merged
merged 4 commits into from
Dec 5, 2023
Merged

优化mark area的smooth的曲线绘制策略 #5877

merged 4 commits into from
Dec 5, 2023

Conversation

taoliujun
Copy link
Contributor

@taoliujun taoliujun commented Dec 4, 2023 •
edited
Loading

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

同时使用mark line和area，都配置了smooth形状，两个mark不能贴合。如图：

image

因为它们的smooth使用了不一样的曲线绘制策略，本pr使它们保持一致的曲线策略，并更新了相关文档。

关联需求：

@taoliujun
Copy link
Contributor Author

丢了测试，稍后重新提交。

@pearmini pearmini self-requested a review December 5, 2023 03:01
@taoliujun
Copy link
Contributor Author

taoliujun commented Dec 5, 2023 •
edited
Loading

补充了test。

这个pr5881不是我的。

@hustcc hustcc mentioned this pull request Dec 5, 2023
Closed
4 tasks
@hustcc
Copy link
Member

hustcc commented Dec 5, 2023

image

增加一个 测试，直接用上面这个图的代码即可。

@taoliujun
Copy link
Contributor Author

@hustcc 好了

@pearmini pearmini merged commit b212242 into antvis:v5 Dec 5, 2023
3 checks passed
@pearmini pearmini mentioned this pull request Dec 5, 2023
Closed
@pearmini
Copy link
Member

pearmini commented Dec 6, 2023

PR 很不错，欢迎加入 G2 的贡献者群！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taoliujun @hustcc @pearmini