-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rangeX and rangeY): add syntactic sugar for data #5879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pearmini
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
很优秀 🤣,下面两个点看看?
- 参考这个 PR feat(mark): add chord mark #5810 添加一下测试案例、文档和官网案例?
- rebase 一下 v5 分支
凌晨提 PR,太 geek 了~ |
想问一下:
|
|
@deletenothing 官网如果还是运行不了的,可以先不加案例,按照 @hustcc 说的即可 |
pearmini
requested changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
passesDescription of change
解决该issue #5803
添加一个默认的 transform,为rangeX和rangeY增加语法糖,使得可以支持以下写法
chart.rangeY().data([350, 600]); 以及
chart.rangeY().data([[350, 400],[500,600]]);
原写法为:chart.rangeY().data([[350, 600]]).encode('y', d => d)