-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(label): add label transform feature exceedAdjust #6209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
requested changes
Apr 27, 2024
单测报错了! |
怪了,我本地跑test是通过的,不知道为啥CI的test没过 |
Pull Request Test Coverage Report for Build 8986952550Details
💛 - Coveralls |
hustcc
reviewed
May 7, 2024
hustcc
reviewed
May 7, 2024
等这个 PR #6222 合并之后,合并进来,然后把那个碰撞的位置还是改成画布大小吧,刚想起来,coordinate 有可能是圆形的,如果用 coordinate 可能出 bug。 export const OverlapHide: LLC<OverlapHideOptions> = (options) => {
const { priority } = options;
return (labels: DisplayObject[], { canvas }) => {
const x = 0;
const y = 0;
const { width, height } = canvas.getConfig(); // 这里
// ...
}
} |
明白 |
hustcc
reviewed
May 7, 2024
hustcc
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
passesDescription of change
close: #6173