New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(facet): legend color do not match pie color #6369

Merged

hustcc merged 1 commit into v5 from facet-pie-legend

Jul 18, 2024

Member

pearmini commented Jul 18, 2024 •

edited

Loading

Before	After

修复在 facet pie 中 legend 颜色和 pie 颜色不一致的问题：

问题原因：facetRect color range 和 pie 的 color range 不一致。
解决办法：应该根据 domain 去推荐 range 的颜色，而不是 values。


          fix(facet): legend color do not match pie color

12c1d69

coveralls commented Jul 18, 2024

Pull Request Test Coverage Report for Build 9989354013

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.622%

Totals
Change from base Build 9967929884:	0.0%
Covered Lines:	10522
Relevant Lines:	11767

💛 - Coveralls

hustcc approved these changes

View reviewed changes

hustcc merged commit eadad96 into v5

2 checks passed

hustcc deleted the facet-pie-legend branch

July 18, 2024 11:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet