Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when update the position of tooltip, calculate the containerOffset #6469

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

interstellarmt
Copy link
Collaborator

fixes #6399

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

After setting the height of the outer container of the canvas to 100vh and the overflow to auto, set the height of the inner container to a relatively high value like 4000px. When scrolling and moving the mouse to the lower half of the chart, the tooltip is displayed in the correct position.image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10933596797

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.705%

Totals Coverage Status
Change from base Build 10732957204: 0.0%
Covered Lines: 10564
Relevant Lines: 11809

💛 - Coveralls

@lxfu1 lxfu1 merged commit ed5a1d6 into v5 Sep 19, 2024
2 checks passed
@lxfu1 lxfu1 deleted the fix-tooltip branch September 19, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞bug: tootltip mount 在 body 上时,如果 chart 容器本身可滚动,tooltip 显示位置
3 participants