Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: walkthrough pie #1877

Closed
wants to merge 7 commits into from
Closed

wip: walkthrough pie #1877

wants to merge 7 commits into from

Conversation

visiky
Copy link
Member

@visiky visiky commented Nov 7, 2020

  • label 切换 inner、outer 时,offset 的响应式适配
  • 中心文本的fontSize 响应式适配
    • 单测
  • 文档走查

利用 css 的 fontSize 可以设置百分比,来使用自适应文本大小的效果:

image image

依赖:
G2: antvis/G2#2981
G2: antvis/G2#2987

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2020

🎊 PR Preview 86f45b4 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1877.surge.sh

🕐 Build time: 580.152s

🤖 By surge-preview

@lgtm-com
Copy link

lgtm-com bot commented Nov 8, 2020

This pull request fixes 1 alert when merging d0d6268 into 5454d86 - view on LGTM.com

fixed alerts:

  • 1 for Overwritten property

@lgtm-com
Copy link

lgtm-com bot commented Nov 8, 2020

This pull request fixes 1 alert when merging 158a269 into 5454d86 - view on LGTM.com

fixed alerts:

  • 1 for Overwritten property

@lgtm-com
Copy link

lgtm-com bot commented Nov 8, 2020

This pull request introduces 3 alerts and fixes 1 when merging 1f69f59 into 5454d86 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Overwritten property

@lgtm-com
Copy link

lgtm-com bot commented Nov 8, 2020

This pull request introduces 2 alerts and fixes 1 when merging d409059 into 5454d86 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

fixed alerts:

  • 1 for Overwritten property

@lgtm-com
Copy link

lgtm-com bot commented Nov 9, 2020

This pull request introduces 2 alerts and fixes 1 when merging 86f45b4 into d88a3fa - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

fixed alerts:

  • 1 for Overwritten property

@visiky visiky closed this Nov 9, 2020
@hustcc hustcc deleted the walkthrough-pie branch November 13, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant