Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walkthrough pie #1879

Merged
merged 7 commits into from
Nov 9, 2020
Merged

walkthrough pie #1879

merged 7 commits into from
Nov 9, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Nov 9, 2020

No description provided.

@visiky visiky requested review from hustcc and lxfu1 November 9, 2020 03:03
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

🎊 PR Preview d88a3fa has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1879.surge.sh

🕐 Build time: 467.694s

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 353121623

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.266%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plots/pie/adaptor.ts 4 5 80.0%
Totals Coverage Status
Change from base Build 350985684: 0.4%
Covered Lines: 3682
Relevant Lines: 3754

💛 - Coveralls

@hustcc hustcc merged commit d88a3fa into master Nov 9, 2020
@hustcc hustcc deleted the feat-pie branch November 9, 2020 03:43
jinhuiWong pushed a commit to jinhuiWong/G2Plot that referenced this pull request Nov 15, 2020
* refactor(docs): 饼图 & 玫瑰图文案和demo走查

* refactor(pie-label): 移除饼图 inner-label 自定义;G2 内置对 string offset 处理

详细:antvis/G2#2981

* docs(pie): 饼图 colorField 为必选,同时显式说明饼图label type有哪些类型

* feat(pie-label): 饼图 label offset 适配,自动根据标签 type 调整 offset

* refactor(docs): 文档优化

* refactor(docs): 文档走查

* feat(testcases): 修复单测
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants