refactor: support config metadata, update script and build config #6460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aarebecca
force-pushed
the
refactor/g6-ssr
branch
from
429891c to
f08844a
Compare
Aarebecca
commented
Oct 31, 2024
| @@ -66,7 +67,19 @@ describe('createGraph', () => { | |||
| it('file pdf', async () => { | |||
| const graph = await fn('pdf'); | |||
|
|
|||
| graph.exportToFile(join(__dirname, '/assets/file')); | |||
| const metadata = { | |||
There was a problem hiding this comment.
这里 pdf 添加 metadata，避免每次测试生成的文件不一致
yvonneyx
reviewed
Oct 31, 2024
| exportToFile: (file: string) => void; | ||
| toBuffer: () => Buffer; | ||
| exportToFile: (file: string, meta?: MetaData) => void; | ||
| toBuffer: (meta?: MetaData) => Buffer; |
There was a problem hiding this comment.
如果下游用户有需求直接拿到导出图片的 buffer，而不是写入到本地文件，可以调这个 API。
比如测试中，可以通过 toBuffer 拿到新生成的文件，并与本地文件进行比较，而不需要先将新截图写入。
yvonneyx
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitForRender用于增加额外等待时长