Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use antialias option in webgl #2458

Merged
merged 2 commits into from
May 15, 2024
Merged

fix: use antialias option in webgl #2458

merged 2 commits into from
May 15, 2024

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented May 15, 2024

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 工作流程
  • 版本更新
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#2431

创建 WebGLDeviceContribution 时会透传 antialias 配置项:

const { enableWebGPU, shaderCompilerPath, antialias } = cfg;

new WebGLDeviceContribution({
    targets: ['webgl2', 'webgl1'],
    antialias,
});

升级到 @antv/g-device-api@1.6.9 即可。效果可以看截图对比,锯齿会减少很多。

💡 需求背景和解决方案

📝 更新日志

语言 更新描述
🇺🇸 英文
🇨🇳 中文

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@xiaoiver
Copy link
Contributor Author

我遇到了另一个问题:如果使用 d3-array@1 启动项目时会报错:

✘ [ERROR] No matching export in "node_modules/.pnpm/d3-array@1.0.0/node_modules/d3-array/index.js" for import "tickIncrement"

    node_modules/.pnpm/d3-scale@2.0.0/node_modules/d3-scale/src/linear.js:1:15:
      1 │ import {ticks, tickIncrement} from "d3-array";

因此我换成了 d3-array@2,不知道之前是不是遇到其他问题才通过 resolution 锁定了低版本

@xiaoiver xiaoiver requested a review from lvisei May 15, 2024 07:15
@lvisei
Copy link
Member

lvisei commented May 15, 2024

因此我换成了 d3-array@2,不知道之前是不是遇到其他问题才通过 resolution 锁定了低版本

应该是的,我看一下现在还需不需要锁定版本

@xiaoiver
Copy link
Contributor Author

测试用例默认是开启抗锯齿的么?如果是的还得更新下截图

@lvisei lvisei mentioned this pull request May 15, 2024
17 tasks
@lvisei
Copy link
Member

lvisei commented May 15, 2024

测试用例默认是开启抗锯齿的么?如果是的还得更新下截图

回复,自动更新截图

image

@lvisei
Copy link
Member

lvisei commented May 15, 2024

/update-snapshots

@lvisei lvisei merged commit 3694768 into master May 15, 2024
14 checks passed
@lvisei lvisei deleted the fix-antialias branch May 15, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants