Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/syb component #67

Merged
merged 20 commits into from
Oct 18, 2022
Merged

Feat/syb component #67

merged 20 commits into from
Oct 18, 2022

Conversation

websybin
Copy link
Contributor

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After

Sorry, something went wrong.

@github-actions
Copy link

github-actions bot commented Oct 13, 2022

🎊 PR Preview 18d7e17 has been successfully built and deployed to https://antvis-LarkMap-preview-pr-67.surge.sh

🕐 Build time: 244.126s

🤖 By surge-preview

@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2022

This pull request introduces 1 alert when merging c282bb3 into 3f627da - view on LGTM.com

new alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2022

This pull request introduces 1 alert when merging 8fee021 into b1a9799 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@websybin websybin requested a review from heiyexing October 14, 2022 07:00
className,
style: styleText,
};
}, [btnText, title, vertical, exitBtnText, exitTitle, position, className, style]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps 里没有依赖 style,style 大概率是一个 CSS 对象,需要依赖的是 styleText,抄作业都没抄全啊

src/index.ts Outdated
FullscreenControlProps as FullscreenProps,
} from './components/Control/FullscreenControl/type';
export { GeoLocateControl, GeoLocateControl as GeoLocate } from './components/Control/GeoLocateControl';
export { GeoLocateControlProps } from './components/Control/GeoLocateControl/type';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有 export 去掉 Control 的名称

position,
className,
style: styleText,
transform: (positions) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transform 是转发 props 里的,不是自己又写一套,那底下 deps 里根本也没必要声明 transform 啊

@@ -0,0 +1,66 @@
import type React from 'react';
import { useMemo, useState } from 'react';
import type { IScaleControlOption} from '@antv/l7';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有格式化

@heiyexing heiyexing merged commit dbd63e4 into feat/component Oct 18, 2022
lvisei added a commit that referenced this pull request Nov 2, 2022
* Feat: 完成 Zoom 的改造 (#68)

* fix: 修复 Popup 更新 DOM 问题

* fix: 修复 CustomControl style 部分属性丢失问题

* feat: 初步完成 ZoomControl 改造

Co-authored-by: yanxiong <oujinhui.ojh@antgroup.com>

* feat: 控件 ZoomControl 新增对 ReactNode 格式的支持 (#70)

Co-authored-by: yanxiong <oujinhui.ojh@antgroup.com>

* Feat/component yanxiong (#71)

* feat: 控件 ZoomControl 新增对 ReactNode 格式的支持

* fix: 还原 package.json

* style: 1. 去除 ZoomControl 已完成的 TODO

Co-authored-by: yanxiong <oujinhui.ojh@antgroup.com>

* Feat/syb component (#67)

* fix: 修复 Popup 更新 DOM 问题

* fix: 修复 CustomControl style 部分属性丢失问题

* feat: 初步完成 ZoomControl 改造

* feat: 初步完成scale改造

* feat: 初步完成Fullscreen控件

* fix: 添加eslint

* fix: 修改controlOptions依赖style项

* feat: 初步完成定位组件

* fix: 删除无用代码

* fix: 修改评论问题

* fix: 撤回代码

* feat: 初步完成导出图片和光标经纬度组件

* feat: 初步完成MapTheme和LayerControl两部分组件

* fix: 修改问题

* fix: 修改type类型

* feat: 添加控件文档

* fix: 文档事件名统一

Co-authored-by: yanxiong <oujinhui.ojh@antgroup.com>
Co-authored-by: syb01094648 <syb01094648@antgroup.com>

* Feat/component yanxiong (#72)

* feat: 控件 ZoomControl 新增对 ReactNode 格式的支持

* fix: 还原 package.json

* style: 1. 去除 ZoomControl 已完成的 TODO

* refactor: 1.迁移 CustomControl 目录结构  2.补充 Control 文档

Co-authored-by: yanxiong <oujinhui.ojh@antgroup.com>

* Feat/syb component (#73)

* fix: 修复 Popup 更新 DOM 问题

* fix: 修复 CustomControl style 部分属性丢失问题

* feat: 初步完成 ZoomControl 改造

* feat: 初步完成scale改造

* feat: 初步完成Fullscreen控件

* fix: 添加eslint

* fix: 修改controlOptions依赖style项

* feat: 初步完成定位组件

* fix: 删除无用代码

* fix: 修改评论问题

* fix: 撤回代码

* feat: 初步完成导出图片和光标经纬度组件

* feat: 初步完成MapTheme和LayerControl两部分组件

* fix: 修改问题

* fix: 修改type类型

* feat: 添加控件文档

* fix: 文档事件名统一

* fix: 修改文档问题

* fix: 修改onSelectChange type类型

* fix: 修改文档定义类型

* fix: 修改文档插槽点击跳转地址

* fix: 修改文档功能

* fix: 修改文档功能

* fix: 文档修改

* fix: 完善截图控件和定位控件demo

* docs: 1.完善控件部分文档说明

* fix: 完善截图控件和定位控件demo

* docs: 1.完善控件部分文档说明

* fix: 修改命名

* refactor: 替换 Control Props 继承方式

Co-authored-by: yanxiong <oujinhui.ojh@antgroup.com>
Co-authored-by: syb01094648 <syb01094648@antgroup.com>

* Merge branch 'feat/component' into feat/syb-component

# Conflicts:
#	package.json
#	src/index.ts

* feat:解决冲突问题

* feat: 补充入口文件 export type

* docs: 调整控件示例高度

* chore: 规范入口文件

Co-authored-by: yanxiong <oujinhui.ojh@antgroup.com>
Co-authored-by: suyubin <84109842+websybin@users.noreply.github.com>
Co-authored-by: syb01094648 <syb01094648@antgroup.com>
Co-authored-by: yunji <yunji.me@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants