Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复单元格宽高为0时的无意义渲染 #2024

Merged
merged 5 commits into from
Jan 3, 2023
Merged

Conversation

wjgogogo
Copy link
Contributor

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

修复点主要包括:

  1. 修复 facet 在计算过程中,如果用户设置了宽高为 0,会意外的被忽略
  2. 在单元格宽高为 0 时,不需要再进行绘制逻辑

🖼️ Screenshot

Config Before After
image image image
image image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Dec 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
antvis-s2 ❌ Failed (Inspect) Dec 30, 2022 at 6:41AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

Size Change: +32 B (0%)

Total Size: 435 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 171 kB +32 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-react/dist/index.min.js 67.4 kB
./packages/s2-react/dist/style.min.css 3.43 kB
./packages/s2-vue/dist/index.min.js 20.5 kB
./packages/s2-vue/dist/style.min.css 1.68 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

你好, @wjgogogo CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @wjgogogo CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Dec 29, 2022
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 77.16% // Head: 76.59% // Decreases project coverage by -0.56% ⚠️

Coverage data is based on head (919e98a) compared to base (a4b14a8).
Patch coverage: 65.79% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2024      +/-   ##
==========================================
- Coverage   77.16%   76.59%   -0.57%     
==========================================
  Files         234      240       +6     
  Lines       11518    12221     +703     
  Branches     2449     2601     +152     
==========================================
+ Hits         8888     9361     +473     
- Misses       1258     1377     +119     
- Partials     1372     1483     +111     
Impacted Files Coverage Δ
packages/s2-core/src/cell/merged-cell.ts 34.78% <ø> (-1.59%) ⬇️
packages/s2-core/src/common/constant/index.ts 90.47% <ø> (-0.60%) ⬇️
packages/s2-core/src/common/icons/gui-icon.ts 86.66% <ø> (-1.71%) ⬇️
packages/s2-core/src/data-set/base-data-set.ts 93.54% <ø> (+25.80%) ⬆️
packages/s2-core/src/facet/header/row.ts 85.18% <0.00%> (ø)
packages/s2-core/src/facet/layout/node.ts 64.04% <ø> (+1.69%) ⬆️
...kages/s2-core/src/interaction/row-column-resize.ts 86.53% <0.00%> (ø)
packages/s2-core/src/sheet-type/pivot-sheet.ts 86.11% <0.00%> (ø)
packages/s2-core/src/sheet-type/table-sheet.ts 89.65% <ø> (+1.72%) ⬆️
packages/s2-core/src/utils/hide-columns.ts 83.87% <ø> (+0.35%) ⬆️
... and 162 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lijinke666 lijinke666 merged commit 9f952fd into master Jan 3, 2023
@lijinke666 lijinke666 deleted the fix-2004 branch January 3, 2023 02:37
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v1.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

stone-lyl added a commit that referenced this pull request Jan 9, 2023
* docs: 修复错误 API 文档格式 (#1976)

* fix: 修复 enableCopy 和 hideMeasureColumn 都开启为 true 时,复制报错问题 (#1984)

* fix: 修复 enableCopy 和 hideMeasureColumn 都开启为 true 时,复制报错问题

* test: 添加单测

Co-authored-by: zishang <lyl275911@antgroup.com>

* feat: 暴露afterRealCellRender,这样能够更灵活的使用datacell (#1970)

Co-authored-by: 杨骥 <yangji@hengshi.com>

* feat: 实现树状模式下可复制 (#1986)

* feat: 树状结构下复制,非叶子节点也需要被复制到

* fix: 修复存在空数据时复制错误的问题

* test: 添加树状结构下复制的单测

* chore: 删除无用代码

* chore: 删除无用代码

Co-authored-by: zishang <lyl275911@antgroup.com>

* feat: 适配链接跳转的判断方式 (#1983)

* fix: 适配链接跳转的判断方式

* fix: 增加点击链接返回参数 id

* test: 完善链接跳转测试

* fix: 透传整个cellData

* docs: 补充链接跳转文档

* test: 修复链接跳转单测

* test: 修复链接跳转单测

Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>

* chore: 🤖 更新 changelog 文件 (#1989)

* feat: 增加 linkFields 参数传入类型 (#1992)

* feat: 增加 linkFields 参数传入类型

* docs: 补充 linkFields 文档

* docs: 补充 linkFields 文档

* fix: 抽取判断是否需要添加链接为公共方法

* fix: 修改公共方法名

Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>

* refactor:  优化智能反色功能 (#1974)

* feat: 优化智能反色需求

* feat: 优化智能反色需求

Co-authored-by: zishang <lyl275911@antgroup.com>

* docs: 官网自定义目录树链接跳转 demo (#2001)

feat: 官网自定义目录树链接跳转 demo

Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>

* fix: gui icon 加载完成后,增加检测步骤,避免无意义的渲染 warning (#1997)

* docs: 更新列分组demo配图 (#1998)

* docs: 修复自定义 schema 示例demo (#2000)

* feat: 添加字段标记中,定制柱状图的长度的功能 (filedValue) (#2002)

* feat: 添加字段标记中,定制柱状图的长度的功能

* chore: 添加字段标记中,定制柱状图的长度的demo

* test: 添加字段标记中,定制柱状图的长度的单测

Co-authored-by: zishang <lyl275911@antgroup.com>

* fix: 明细表紧凑模式宽度计算错误 (#2006)

* fix: 明细表紧凑模式宽度计算错误

* test: 补充紧凑模式测试用例

* test: table-facet测试异常

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* chore: 🤖 更新 changelog 文件 (#2005)

* fix: 明细表linkField失效 (#2007)

* fix: 明细表linkField失效

* test: 补充测试用例

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* chore: 🤖 更新 changelog 文件 (#2008)

* feat: 子弹图为空时使用placeholder占位 (#2010)

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* fix: 列头label存在数组,复制导出列头层级补齐错误 (#1990)

* fix: 列头label存在数组,层级补齐错误
当headers存在数组,但不是每一列都存在数组时,仅需要对header[0]为数组的项进行补齐(当列各层级都是string类型时会补齐过多的空格)

* test: 添加单测

* feat: selected cell highlight (#1878)

* feat: upgrade selectedCellHighlight option & 修复 selectedCellHighlight 单元格因滚动状态失效的问题

* feat: selectedCellHighlight option 复制功能

* fix: selectedCellHighlight 为 false 的情况

* fix: 修复单测报错

* feat: 补充单测

* feat: selectedCellHighlight 配置项补充文档

* refactor: 调整 BaseDataSet.getRowData 为抽象方法

* refactor: remove unused code

* refactor: 调整 selectedCellHighlight option 实现逻辑

* feat: 修改文档 & react playground

* refactor: 调整 selectedCellHighlight option 复制实现

* feat: 调整单测

* fix: type error

* refactor: selectedCellHighlight option 调整数据单元格点击事件 headerCells 存储逻辑

* feat: selectedCellHighlight option 统一刷选的交互 & afterSelectDataCells 函数提取

* refactor: remove duplicate constant

* refactor: selectedCellHighlight option selectedCellHighlightAdaptor 调整为 getSelectedCellHighlight

* fix: lint error

* fix: unit test

Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: stone <stone-lyl@users.noreply.github.com>

* fix: bullet占位符绘制错误 (#2022)

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* fix: 修复单元格宽高为0时的无意义渲染 (#2024)

* fix: 修复单元格宽高为0时的无意义渲染

* fix: 修复 facet 处理过程中忽略 0 的情况

* test: 修复单测

* test: 添加宽高为 0 时的单元格测试

* refactor: 在 base cell 中应用 shouldInit

* fix : 修复点击行列头无法整行高亮的问题 (#2025)

* fix: 修复点击行列头无法整行高亮的问题

* test: 添加修复点击行列头无法整行高亮的问题的单测

* docs: 完善 selectedCellHighlight 相关文档

* docs: 完善 selectedCellHighlight 相关文档

Co-authored-by: zishang <lyl275911@antgroup.com>

* docs: 替换antgroup主站 (#2029)

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* chore: 🤖 更新 changelog 文件 (#2028)

* fix(layout): 修复无列头时行头对应的角头不显示 close #1929 (#2026)

* fix(layout): 修复无列头时行头对应的角头不显示 close #1929

* test: 修复测试

* refactor: rowCells 重命名为 currentRow,避免与行头 rowCell 定义冲突 (#2032)

Co-authored-by: zishang <lyl275911@antgroup.com>

* chore: 修复严格模式下 eslint 错误的问题

Co-authored-by: Jinke Li <a1231236677287@163.com>
Co-authored-by: zishang <lyl275911@antgroup.com>
Co-authored-by: yangji <511415343@qq.com>
Co-authored-by: 杨骥 <yangji@hengshi.com>
Co-authored-by: GaoFuhong <43170533+GaoFuhong@users.noreply.github.com>
Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>
Co-authored-by: Wenjun Xu <906626481@qq.com>
Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: 刘嘉一 <lcx.seima@gmail.com>
Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>
Co-authored-by: 照明胧 <25151442+mmmml-zhao@users.noreply.github.com>
Co-authored-by: LHC8888 <LHCyeah@126.com>
lijinke666 added a commit that referenced this pull request Jan 16, 2023
* docs: 修复错误 API 文档格式 (#1976)

* fix: 修复 enableCopy 和 hideMeasureColumn 都开启为 true 时,复制报错问题 (#1984)

* fix: 修复 enableCopy 和 hideMeasureColumn 都开启为 true 时,复制报错问题

* test: 添加单测

Co-authored-by: zishang <lyl275911@antgroup.com>

* feat: 暴露afterRealCellRender,这样能够更灵活的使用datacell (#1970)

Co-authored-by: 杨骥 <yangji@hengshi.com>

* feat: 实现树状模式下可复制 (#1986)

* feat: 树状结构下复制,非叶子节点也需要被复制到

* fix: 修复存在空数据时复制错误的问题

* test: 添加树状结构下复制的单测

* chore: 删除无用代码

* chore: 删除无用代码

Co-authored-by: zishang <lyl275911@antgroup.com>

* feat: 适配链接跳转的判断方式 (#1983)

* fix: 适配链接跳转的判断方式

* fix: 增加点击链接返回参数 id

* test: 完善链接跳转测试

* fix: 透传整个cellData

* docs: 补充链接跳转文档

* test: 修复链接跳转单测

* test: 修复链接跳转单测

Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>

* chore: 🤖 更新 changelog 文件 (#1989)

* feat: 增加 linkFields 参数传入类型 (#1992)

* feat: 增加 linkFields 参数传入类型

* docs: 补充 linkFields 文档

* docs: 补充 linkFields 文档

* fix: 抽取判断是否需要添加链接为公共方法

* fix: 修改公共方法名

Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>

* refactor:  优化智能反色功能 (#1974)

* feat: 优化智能反色需求

* feat: 优化智能反色需求

Co-authored-by: zishang <lyl275911@antgroup.com>

* docs: 官网自定义目录树链接跳转 demo (#2001)

feat: 官网自定义目录树链接跳转 demo

Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>

* fix: gui icon 加载完成后,增加检测步骤,避免无意义的渲染 warning (#1997)

* docs: 更新列分组demo配图 (#1998)

* docs: 修复自定义 schema 示例demo (#2000)

* feat: 添加字段标记中,定制柱状图的长度的功能 (filedValue) (#2002)

* feat: 添加字段标记中,定制柱状图的长度的功能

* chore: 添加字段标记中,定制柱状图的长度的demo

* test: 添加字段标记中,定制柱状图的长度的单测

Co-authored-by: zishang <lyl275911@antgroup.com>

* fix: 明细表紧凑模式宽度计算错误 (#2006)

* fix: 明细表紧凑模式宽度计算错误

* test: 补充紧凑模式测试用例

* test: table-facet测试异常

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* chore: 🤖 更新 changelog 文件 (#2005)

* fix: 明细表linkField失效 (#2007)

* fix: 明细表linkField失效

* test: 补充测试用例

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* chore: 🤖 更新 changelog 文件 (#2008)

* feat: 子弹图为空时使用placeholder占位 (#2010)

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* fix: 列头label存在数组,复制导出列头层级补齐错误 (#1990)

* fix: 列头label存在数组,层级补齐错误
当headers存在数组,但不是每一列都存在数组时,仅需要对header[0]为数组的项进行补齐(当列各层级都是string类型时会补齐过多的空格)

* test: 添加单测

* feat: selected cell highlight (#1878)

* feat: upgrade selectedCellHighlight option & 修复 selectedCellHighlight 单元格因滚动状态失效的问题

* feat: selectedCellHighlight option 复制功能

* fix: selectedCellHighlight 为 false 的情况

* fix: 修复单测报错

* feat: 补充单测

* feat: selectedCellHighlight 配置项补充文档

* refactor: 调整 BaseDataSet.getRowData 为抽象方法

* refactor: remove unused code

* refactor: 调整 selectedCellHighlight option 实现逻辑

* feat: 修改文档 & react playground

* refactor: 调整 selectedCellHighlight option 复制实现

* feat: 调整单测

* fix: type error

* refactor: selectedCellHighlight option 调整数据单元格点击事件 headerCells 存储逻辑

* feat: selectedCellHighlight option 统一刷选的交互 & afterSelectDataCells 函数提取

* refactor: remove duplicate constant

* refactor: selectedCellHighlight option selectedCellHighlightAdaptor 调整为 getSelectedCellHighlight

* fix: lint error

* fix: unit test

Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: stone <stone-lyl@users.noreply.github.com>

* fix: bullet占位符绘制错误 (#2022)

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* fix: 修复单元格宽高为0时的无意义渲染 (#2024)

* fix: 修复单元格宽高为0时的无意义渲染

* fix: 修复 facet 处理过程中忽略 0 的情况

* test: 修复单测

* test: 添加宽高为 0 时的单元格测试

* refactor: 在 base cell 中应用 shouldInit

* fix : 修复点击行列头无法整行高亮的问题 (#2025)

* fix: 修复点击行列头无法整行高亮的问题

* test: 添加修复点击行列头无法整行高亮的问题的单测

* docs: 完善 selectedCellHighlight 相关文档

* docs: 完善 selectedCellHighlight 相关文档

Co-authored-by: zishang <lyl275911@antgroup.com>

* docs: 替换antgroup主站 (#2029)

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* chore: 🤖 更新 changelog 文件 (#2028)

* fix(layout): 修复无列头时行头对应的角头不显示 close #1929 (#2026)

* fix(layout): 修复无列头时行头对应的角头不显示 close #1929

* test: 修复测试

* refactor: rowCells 重命名为 currentRow,避免与行头 rowCell 定义冲突 (#2032)

Co-authored-by: zishang <lyl275911@antgroup.com>

* chore: 修复严格模式下 eslint 错误的问题

* test: 修复linkField测试

* chore: 修复 lint 问题

* test: 修复 cornerBBox 单测问题

* test: 修复 link jump 单测

* test: table-sheet 单测

* fix: 明细表列头clip错误

* chore: compressed action 优化

* fix: 修复列头隐藏时角头不显示

* test: g-mini-charts 单测文字处理

* test: 修复 next 版本,不将 border width 作为 Interval 宽度。

* test: 更新 corner 单测

* fix: 明细表compact模式宽度计算错误

* test: 修改单测,添加border width

Co-authored-by: Jinke Li <a1231236677287@163.com>
Co-authored-by: zishang <lyl275911@antgroup.com>
Co-authored-by: yangji <511415343@qq.com>
Co-authored-by: 杨骥 <yangji@hengshi.com>
Co-authored-by: GaoFuhong <43170533+GaoFuhong@users.noreply.github.com>
Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>
Co-authored-by: Wenjun Xu <906626481@qq.com>
Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: 刘嘉一 <lcx.seima@gmail.com>
Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>
Co-authored-by: 照明胧 <25151442+mmmml-zhao@users.noreply.github.com>
Co-authored-by: LHC8888 <LHCyeah@126.com>
lijinke666 added a commit that referenced this pull request Jan 16, 2023
* docs: 修复错误 API 文档格式 (#1976)

* fix: 修复 enableCopy 和 hideMeasureColumn 都开启为 true 时,复制报错问题 (#1984)

* fix: 修复 enableCopy 和 hideMeasureColumn 都开启为 true 时,复制报错问题

* test: 添加单测

Co-authored-by: zishang <lyl275911@antgroup.com>

* feat: 暴露afterRealCellRender,这样能够更灵活的使用datacell (#1970)

Co-authored-by: 杨骥 <yangji@hengshi.com>

* feat: 实现树状模式下可复制 (#1986)

* feat: 树状结构下复制,非叶子节点也需要被复制到

* fix: 修复存在空数据时复制错误的问题

* test: 添加树状结构下复制的单测

* chore: 删除无用代码

* chore: 删除无用代码

Co-authored-by: zishang <lyl275911@antgroup.com>

* feat: 适配链接跳转的判断方式 (#1983)

* fix: 适配链接跳转的判断方式

* fix: 增加点击链接返回参数 id

* test: 完善链接跳转测试

* fix: 透传整个cellData

* docs: 补充链接跳转文档

* test: 修复链接跳转单测

* test: 修复链接跳转单测

Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>

* chore: 🤖 更新 changelog 文件 (#1989)

* feat: 增加 linkFields 参数传入类型 (#1992)

* feat: 增加 linkFields 参数传入类型

* docs: 补充 linkFields 文档

* docs: 补充 linkFields 文档

* fix: 抽取判断是否需要添加链接为公共方法

* fix: 修改公共方法名

Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>

* refactor:  优化智能反色功能 (#1974)

* feat: 优化智能反色需求

* feat: 优化智能反色需求

Co-authored-by: zishang <lyl275911@antgroup.com>

* docs: 官网自定义目录树链接跳转 demo (#2001)

feat: 官网自定义目录树链接跳转 demo

Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>

* fix: gui icon 加载完成后,增加检测步骤,避免无意义的渲染 warning (#1997)

* docs: 更新列分组demo配图 (#1998)

* docs: 修复自定义 schema 示例demo (#2000)

* feat: 添加字段标记中,定制柱状图的长度的功能 (filedValue) (#2002)

* feat: 添加字段标记中,定制柱状图的长度的功能

* chore: 添加字段标记中,定制柱状图的长度的demo

* test: 添加字段标记中,定制柱状图的长度的单测

Co-authored-by: zishang <lyl275911@antgroup.com>

* fix: 明细表紧凑模式宽度计算错误 (#2006)

* fix: 明细表紧凑模式宽度计算错误

* test: 补充紧凑模式测试用例

* test: table-facet测试异常

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* chore: 🤖 更新 changelog 文件 (#2005)

* fix: 明细表linkField失效 (#2007)

* fix: 明细表linkField失效

* test: 补充测试用例

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* chore: 🤖 更新 changelog 文件 (#2008)

* feat: 子弹图为空时使用placeholder占位 (#2010)

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* fix: 列头label存在数组,复制导出列头层级补齐错误 (#1990)

* fix: 列头label存在数组,层级补齐错误
当headers存在数组,但不是每一列都存在数组时,仅需要对header[0]为数组的项进行补齐(当列各层级都是string类型时会补齐过多的空格)

* test: 添加单测

* feat: selected cell highlight (#1878)

* feat: upgrade selectedCellHighlight option & 修复 selectedCellHighlight 单元格因滚动状态失效的问题

* feat: selectedCellHighlight option 复制功能

* fix: selectedCellHighlight 为 false 的情况

* fix: 修复单测报错

* feat: 补充单测

* feat: selectedCellHighlight 配置项补充文档

* refactor: 调整 BaseDataSet.getRowData 为抽象方法

* refactor: remove unused code

* refactor: 调整 selectedCellHighlight option 实现逻辑

* feat: 修改文档 & react playground

* refactor: 调整 selectedCellHighlight option 复制实现

* feat: 调整单测

* fix: type error

* refactor: selectedCellHighlight option 调整数据单元格点击事件 headerCells 存储逻辑

* feat: selectedCellHighlight option 统一刷选的交互 & afterSelectDataCells 函数提取

* refactor: remove duplicate constant

* refactor: selectedCellHighlight option selectedCellHighlightAdaptor 调整为 getSelectedCellHighlight

* fix: lint error

* fix: unit test

Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: stone <stone-lyl@users.noreply.github.com>

* fix: bullet占位符绘制错误 (#2022)

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* fix: 修复单元格宽高为0时的无意义渲染 (#2024)

* fix: 修复单元格宽高为0时的无意义渲染

* fix: 修复 facet 处理过程中忽略 0 的情况

* test: 修复单测

* test: 添加宽高为 0 时的单元格测试

* refactor: 在 base cell 中应用 shouldInit

* fix : 修复点击行列头无法整行高亮的问题 (#2025)

* fix: 修复点击行列头无法整行高亮的问题

* test: 添加修复点击行列头无法整行高亮的问题的单测

* docs: 完善 selectedCellHighlight 相关文档

* docs: 完善 selectedCellHighlight 相关文档

Co-authored-by: zishang <lyl275911@antgroup.com>

* docs: 替换antgroup主站 (#2029)

Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>

* chore: 🤖 更新 changelog 文件 (#2028)

* fix(layout): 修复无列头时行头对应的角头不显示 close #1929 (#2026)

* fix(layout): 修复无列头时行头对应的角头不显示 close #1929

* test: 修复测试

* refactor: rowCells 重命名为 currentRow,避免与行头 rowCell 定义冲突 (#2032)

Co-authored-by: zishang <lyl275911@antgroup.com>

* chore: 修复严格模式下 eslint 错误的问题

* test: 修复linkField测试

* chore: 修复 lint 问题

* test: 修复 cornerBBox 单测问题

* test: 修复 link jump 单测

* test: table-sheet 单测

* fix: 明细表列头clip错误

* chore: compressed action 优化

* fix: 修复列头隐藏时角头不显示

* test: g-mini-charts 单测文字处理

* refactor: 移除所有 @deprecated api

* test: 修复 next 版本,不将 border width 作为 Interval 宽度。

* test: 更新 corner 单测

* test: 单测修复

* test: react 单测修复

Co-authored-by: Jinke Li <a1231236677287@163.com>
Co-authored-by: stone <stone-lyl@users.noreply.github.com>
Co-authored-by: zishang <lyl275911@antgroup.com>
Co-authored-by: yangji <511415343@qq.com>
Co-authored-by: 杨骥 <yangji@hengshi.com>
Co-authored-by: GaoFuhong <43170533+GaoFuhong@users.noreply.github.com>
Co-authored-by: gaofuhong.gfh <gaofuhong.gfh@antgroup.com>
Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: 刘嘉一 <lcx.seima@gmail.com>
Co-authored-by: 沫君 <chuxiao.lcx@alibaba-inc.com>
Co-authored-by: 照明胧 <25151442+mmmml-zhao@users.noreply.github.com>
Co-authored-by: LHC8888 <LHCyeah@126.com>
Co-authored-by: stone <stone-lyl@outlook.com>
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

wjgogogo added a commit that referenced this pull request Oct 25, 2023
* fix: 修复单元格宽高为0时的无意义渲染

* fix: 修复 facet 处理过程中忽略 0 的情况

* test: 修复单测

* test: 添加宽高为 0 时的单元格测试

* refactor: 在 base cell 中应用 shouldInit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants