Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buttons unify #2424

Closed
wants to merge 2 commits into from
Closed

fix: buttons unify #2424

wants to merge 2 commits into from

Conversation

ai-qing-hai
Copy link
Contributor

和 其他子站 按钮顺便保持一致

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 6:39am

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Size Change: 0 B

Total Size: 439 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 175 kB
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-react/dist/index.min.js 68 kB
./packages/s2-react/dist/style.min.css 3.42 kB
./packages/s2-vue/dist/index.min.js 20.5 kB
./packages/s2-vue/dist/style.min.css 1.68 kB

compressed-size-action

Copy link
Contributor

你好, @ai-qing-hai CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @ai-qing-hai CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Nov 21, 2023
@lijinke666
Copy link
Member

请 rebase 一下 commit ,请用 docs:前缀,不然 changelog 会带上这条

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (1adc25d) 76.48% compared to head (6735d65) 76.77%.
Report is 92 commits behind head on master.

Files Patch % Lines
packages/s2-core/src/facet/frozen-facet.ts 86.06% 2 Missing and 26 partials ⚠️
packages/s2-core/src/data-set/pivot-data-set.ts 72.85% 2 Missing and 17 partials ⚠️
packages/s2-core/src/facet/pivot-facet.ts 81.63% 1 Missing and 8 partials ⚠️
packages/s2-core/src/utils/text.ts 50.00% 7 Missing ⚠️
...mponents/sheets/editable-sheet/edit-cell/index.tsx 50.00% 5 Missing and 1 partial ⚠️
...s/s2-core/src/facet/layout/build-gird-hierarchy.ts 85.29% 1 Missing and 4 partials ⚠️
packages/s2-core/src/facet/layout/layout-hooks.ts 0.00% 3 Missing and 1 partial ⚠️
...act/src/components/sheets/editable-sheet/index.tsx 33.33% 3 Missing and 1 partial ⚠️
packages/s2-core/src/facet/base-facet.ts 85.71% 0 Missing and 3 partials ⚠️
packages/s2-core/src/facet/table-facet.ts 92.10% 1 Missing and 2 partials ⚠️
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2424      +/-   ##
==========================================
+ Coverage   76.48%   76.77%   +0.29%     
==========================================
  Files         240      242       +2     
  Lines       12312    12634     +322     
  Branches     2630     2723      +93     
==========================================
+ Hits         9417     9700     +283     
+ Misses       1377     1350      -27     
- Partials     1518     1584      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ai-qing-hai ai-qing-hai deleted the fix-dumi-buttons branch November 21, 2023 07:22
@ai-qing-hai
Copy link
Contributor Author

请 rebase 一下 commit ,请用 docs:前缀,不然 changelog 会带上这条

#2425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants