Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 React 18 StrictMode 同时挂载两个表格的问题 #2432

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Nov 23, 2023

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

React 18 StrictMode 在非生产环境下会强制执行两次, 导致会挂载两个 canvas, 体验不是很好

🖼️ Screenshot

Before After
image image

🔗 Related issue link

#2373 遗留问题

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Nov 23, 2023 3:29am

@github-actions github-actions bot added the pr(fix) bug fix label Nov 23, 2023
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Nov 23, 2023
Copy link
Contributor

github-actions bot commented Nov 23, 2023

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Nov 23, 2023
Copy link
Contributor

Size Change: +60 B (0%)

Total Size: 311 kB

Filename Size Change
./packages/s2-react/dist/index.min.js 67.5 kB +60 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 216 kB
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/style.min.css 3.99 kB
./packages/s2-vue/dist/index.min.js 20.2 kB
./packages/s2-vue/dist/style.min.css 1.98 kB

compressed-size-action

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecdc9c8) 75.77% compared to head (081eaea) 77.74%.
Report is 218 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2432      +/-   ##
==========================================
+ Coverage   75.77%   77.74%   +1.97%     
==========================================
  Files         257      270      +13     
  Lines       11994    12047      +53     
  Branches     2464     2443      -21     
==========================================
+ Hits         9088     9366     +278     
+ Misses       1398     1169     -229     
- Partials     1508     1512       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit 7c4da43 into next Nov 28, 2023
13 of 14 checks passed
@wjgogogo wjgogogo deleted the fix-react-strict-mode branch November 28, 2023 06:54
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants