Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wheel scroll error! #2643

Merged
merged 8 commits into from
May 31, 2024
Merged

fix: wheel scroll error! #2643

merged 8 commits into from
May 31, 2024

Conversation

DavisYao88
Copy link

👀 PR includes

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

修复使用触摸板快速反复滚动时，堆内存溢出，导致表格卡死。

🖼️ Screenshot

Before After
f7a572ed5556fd4ca6c89fc7e9981271 8E764474-A98E-4ae2-BC14-C589818CB69C

🔗 Related issue link

close #2627

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) May 31, 2024 9:16am

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Apr 1, 2024
@github-actions github-actions bot added the pr(fix) bug fix label Apr 1, 2024
@EliazTray
Copy link

EliazTray commented May 24, 2024 •
edited
Loading

It looks like two months have passed, any progress here?
Thanks~

@DavisYao88 DavisYao88 closed this May 25, 2024
@DavisYao88 DavisYao88 reopened this May 25, 2024
@lijinke666
Copy link
Member

不好意思，下周处理该 pr ，感谢贡献

@lijinke666
Copy link
Member

@DavisYao88 请解决下冲突

@DavisYao88
Copy link
Author

@DavisYao88 请解决下冲突

已解决

lijinke666
lijinke666 reviewed May 27, 2024
View reviewed changes
packages/s2-react/playground/index.tsx Outdated Show resolved Hide resolved
packages/s2-react/playground/components/BigDataSheet.tsx Outdated Show resolved Hide resolved
packages/s2-react/playground/components/BigDataSheet.tsx Outdated Show resolved Hide resolved
packages/s2-core/src/facet/base-facet.ts Outdated Show resolved Hide resolved
packages/s2-core/src/facet/base-facet.ts Outdated Show resolved Hide resolved
lijinke666
lijinke666 reviewed May 27, 2024
View reviewed changes
packages/s2-core/src/facet/base-facet.ts Outdated Show resolved Hide resolved
packages/s2-core/src/facet/base-facet.ts Outdated Show resolved Hide resolved
@lijinke666 lijinke666 linked an issue May 27, 2024 that may be closed by this pull request
透视表列多时，使用触摸板左右快速滑动，会报栈溢出错误 #2627
Closed
5 tasks
lijinke666
lijinke666 reviewed May 27, 2024
View reviewed changes
packages/s2-core/src/facet/base-facet.ts Outdated Show resolved Hide resolved
packages/s2-core/src/facet/base-facet.ts Show resolved Hide resolved
packages/s2-core/src/facet/base-facet.ts Outdated Show resolved Hide resolved
packages/s2-core/src/facet/base-facet.ts Show resolved Hide resolved
@lijinke666
Copy link
Member

lijinke666 commented May 27, 2024 •
edited
Loading

这个 case 比较特殊, 可以不写单测, 这个报错可忽略, 已知问题

image

@lijinke666
Copy link
Member

image

这个问题请看下, 我觉得是有问题的

@DavisYao88
Copy link
Author

image

这个问题请看下, 我觉得是有问题的

确实如你所说，放在那里更严谨。已处理

@lijinke666 lijinke666 merged commit 43cf364 into antvis:next May 31, 2024
2 of 3 checks passed
@lijinke666
Copy link
Member

下周发布

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijinke666 lijinke666 lijinke666 approved these changes

@wjgogogo wjgogogo Awaiting requested review from wjgogogo

@wuhaiyang wuhaiyang Awaiting requested review from wuhaiyang

Assignees

@DavisYao88 DavisYao88

Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

透视表列多时，使用触摸板左右快速滑动，会报栈溢出错误
3 participants
@DavisYao88 @EliazTray @lijinke666