feat: 新增 s2.facet.getContentWidth() API #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2.facet.getContentHeight() 和 s2.facet.getContentWidth() BREAKING CHANGE: 移除 s2.getContentHeight() API
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lijinke666
commented
Aug 30, 2024
| @@ -637,12 +641,6 @@ export abstract class BaseFacet { | |||
| }; | |||
| } | |||
|
|
|||
| public getContentHeight(): number { | |||
There was a problem hiding this comment.
这个在 table-facet 中重写, 其实只有 pivot-facet 使用, 所以摞到相应的位置中
lijinke666
commented
Aug 30, 2024
| /** | ||
| * 获取当前表格实际内容高度 | ||
| */ | ||
| public getContentHeight(): number { |
|
Size Change: +6 B (0%) Total Size: 329 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2883 +/- ##
==========================================
+ Coverage 75.77% 80.80% +5.03%
==========================================
Files 257 180 -77
Lines 11994 10415 -1579
Branches 2464 2360 -104
==========================================
- Hits 9088 8416 -672
+ Misses 1398 555 -843
+ Partials 1508 1444 -64 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version @antv/s2-v2.0.0-next.28 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
✨ Feature
📝 Description
新增
BREAKING CHANGE: 移除
🖼️ Screenshot
🔗 Related issue link
close #2881
🔍 Self-Check before the merge