Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 expandDepth 在自定义行头场景下不生效 #2895

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Sep 12, 2024

👀 PR includes

🐛 Bugfix

📝 Description

自定义行头节点的树状模式场景未适配, 导致和普通树状模式表现不一致

  style: {
    rowCell: {
      expandDepth: 0,
    },
  }

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Sep 12, 2024 3:58am

Copy link
Contributor

Size Change: +16 B (0%)

Total Size: 329 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 229 kB +16 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.9 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.80%. Comparing base (ecdc9c8) to head (3d759ad).
Report is 432 commits behind head on next.

Files with missing lines Patch % Lines
...-core/src/facet/layout/build-row-tree-hierarchy.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2895      +/-   ##
==========================================
+ Coverage   75.77%   80.80%   +5.03%     
==========================================
  Files         257      180      -77     
  Lines       11994    10413    -1581     
  Branches     2464     2361     -103     
==========================================
- Hits         9088     8414     -674     
+ Misses       1398      554     -844     
+ Partials     1508     1445      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 linked an issue Sep 12, 2024 that may be closed by this pull request
4 tasks
@lijinke666 lijinke666 merged commit d83a816 into next Sep 18, 2024
14 of 15 checks passed
@lijinke666 lijinke666 deleted the fix-custom-tree-expand-depth branch September 18, 2024 10:53
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 expandDepth is not working in custom directory
2 participants