-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support react 17 #2968
fix: support react 17 #2968
Conversation
@NewByVector Please provide us with more info about this pull request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2968 +/- ##
==========================================
+ Coverage 27.29% 33.88% +6.58%
==========================================
Files 197 273 +76
Lines 14192 17338 +3146
Branches 3014 3766 +752
==========================================
+ Hits 3874 5875 +2001
- Misses 10146 11058 +912
- Partials 172 405 +233
Flags with carried forward coverage won't be shown. Click here to find out more.
|
编译报错,react 17.0.2 |
🎉 This PR is included in the following release 🎉
Thanks for being a part of the AntV community! 💪💯 |
🎉 This PR is included in the following release 🎉
Thanks for being a part of the AntV community! 💪💯 |
|
积重难返 我按社区的方案试了下,因为目前项目使用的reacct是16.x,很多东西有限制,还是会有各种报错。 然后我把react升级到18,x6和@antv/x6-react-shape升级到2.x,除开升级React到18可能带来的未知的问题外,升级后的x6也带来很多报错,例如: 再尝试下,如果效果还不佳的话,可能就要放弃升级的方案了,考虑限制节点数量的方案 |
🎉 This PR is included in the following release 🎉
Thanks for being a part of the AntV community! 💪💯 |
Description
Motivation and Context
Types of changes
Self Check before Merge