Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed binding group layout validation error #207

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

re-ovo
Copy link

@re-ovo re-ovo commented Nov 10, 2024

WebGPU does not allow automatically inferred layouts to be shared between different pipelines

🤔 This is a

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

使用WebGPU后端时发生报错:

The current pipeline ([RenderPipeline (unlabeled)]) was created with a default layout, and is not compatible with the [BindGroup (unlabeled)] set at group index 0 which uses a [BindGroupLayout (unlabeled)] that was not created by the pipeline. Either use the bind group layout returned by calling getBindGroupLayout(0) on the pipeline when creating the bind group, or provide an explicit pipeline layout when creating the pipeline.
 - While encoding [RenderPassEncoder (unlabeled)].DrawIndexed(3600, 1, 0, 0, 0).
 - While finishing [CommandEncoder (unlabeled)].

💡 Background and solution

如果要共享绑定组的话,只能手动创建BindGroupLayout,目前是使用'auto'自动推断布局,不能在不同Pipeline之间共享。
这个PR直接为每个pipeline创建单独的布局。

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

WebGPU does not allow automatically inferred layouts to be shared between different pipelines
@wang1212 wang1212 changed the base branch from master to release November 20, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant