feat: support the monaco editor on example #195

NewByVector · 2020-07-21T08:35:02Z

support monaco editor by config editorType in gatsby-config.js
support view source data if source code includes fetch statements
fix the error in g2 example

tests-checker

Could you please add tests to make sure this change works as expected?

afc163 · 2020-07-21T08:46:00Z

使用英文和语义化的 commit messsage。
git 信息绑定有问题。

使用精简有语义的 PR 标题。

NewByVector · 2020-07-22T03:40:42Z

done

afc163 · 2020-07-22T03:56:10Z

rebase 一下 master，解决一下冲突。

afc163 · 2020-07-22T03:56:32Z

另外，Semantic Pull Request 还是 ❌ 的。

NewByVector · 2020-07-22T08:21:59Z

done

afc163 · 2020-07-22T09:17:54Z

npm run lint 有问题，修复一下，不知道为啥 PR 的 CI 没开启。
这段代码前多了几个空格。

拖动中间分隔线的时候，编辑器宽度没有自适应。拖放浏览器宽度同样可重现。

CodeMirror 直接干掉吧，两个编辑器体积很大的。
如果统一用 Data panel 来放数据，这里代码里的 fetch 是什么意思？是否写法也要改变一下。

代码底部有大片空白，导致多余滚动条出现。

afc163 · 2020-07-22T09:23:15Z

example/src/index.d.ts

+     */
+    color(field: string, cfg?: string | string[]): any;
+  }
+}


能直接使用 G2 自己的定义么，这里都要每个库单独定义一下挺重复和麻烦的。

NewByVector · 2020-07-22T12:55:58Z

fetch那里是因为：现在example中fetch写法太多，改动起来成本比较高，暂时不改变原来js写法，只把data显示出来
G2自己的类型定义文件interface.d.ts内容不全，导致不能显示提示。后面会优化每个项目的interface.ts文件，直接读这个文件传给编辑器即可
其他问题已经修复

afc163 · 2020-07-23T05:58:08Z

解决了的问题请勾掉。

另外 ci 是挂的，请检查。

afc163 · 2020-07-23T05:58:50Z

fetch那里是因为：现在example中fetch写法太多，改动起来成本比较高，暂时不改变原来js写法，只把data显示出来

可以先改一个看看真实代码的效果。

NewByVector · 2020-07-23T09:17:42Z

npm run lint 有问题，修复一下，不知道为啥 PR 的 CI 没开启。

这段代码前多了几个空格。

拖动中间分隔线的时候，编辑器宽度没有自适应。拖放浏览器宽度同样可重现。

CodeMirror 直接干掉吧，两个编辑器体积很大的。

如果统一用 Data panel 来放数据，这里代码里的 fetch 是什么意思？是否写法也要改变一下。

代码底部有大片空白，导致多余滚动条出现。

解决了的问题请勾掉。

另外 ci 是挂的，请检查。

彻底删除codemirror(太粗心了(⊙o⊙)…)
修复单元测试报错
monaco使用懒加载，解决build下报错

afc163 · 2020-07-27T05:23:55Z

example/gatsby-config.js

@@ -91,6 +95,7 @@ module.exports = {
      dependencies: {
        '@antv/l7': 'beta',
      },
+      extraLib: extraLibDeclare,


这个能自动读出来么，让每个库都去这么写一下没必要。

每个库单独提供api-extractor.json（api-extractor的配置文件），在gatsby-theme-antv中统一提取.d.ts文件

afc163 · 2020-07-29T02:27:16Z

@antv/gatsby-theme-antv/package.json

@@ -139,6 +139,7 @@
    "access": "public"
  },
  "devDependencies": {
+    "@microsoft/api-extractor": "^7.9.2",


dependencies

afc163 · 2020-07-29T04:09:19Z

我发个版本先，@NewByVector 的 npm 账号是多少，我加你权限，之后有问题随时改随时发。

NewByVector · 2020-07-29T06:21:02Z

我发个版本先，@NewByVector 的 npm 账号是多少，我加你权限，之后有问题随时改随时发。

newbyvector

afc163 · 2020-07-29T06:38:01Z

https://github.com/antvis/gatsby-theme-antv/releases/tag/0.11.0 published

feat:1.支持monaco编辑器，支持智能提示 2.解决example中G2 demo不能运行的bug

1b194a4

pr-triage bot added the PR: unreviewed label Jul 21, 2020

tests-checker bot suggested changes Jul 21, 2020

View reviewed changes

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Jul 21, 2020

NewByVector changed the title ~~feat:1.支持monaco编辑器，支持智能提示 2.解决example中G2 demo不能运行的bug~~ feat:support the monaco editor on example Jul 21, 2020

Merge branch 'master' of https://github.com/antvis/gatsby-theme-antv

3fc4acf

pr-triage bot added PR: unreviewed and removed PR: reviewed-changes-requested labels Jul 22, 2020

NewByVector changed the title ~~feat:support the monaco editor on example~~ feat: support the monaco editor on example Jul 22, 2020

auto-add-label bot added the enhancement New feature or request label Jul 22, 2020

afc163 reviewed Jul 22, 2020

View reviewed changes

fix: optimize the Monaco Editor's interactions

651e9ba

fix: fix ci error

8d80634

NewByVector added 3 commits July 23, 2020 17:44

fix: optimize the doc

9c6d0c2

fix: fix lint error

0d02127

fix: fix eslint process jam problem

16f726d

afc163 reviewed Jul 27, 2020

View reviewed changes

fix: unified processing of .d.ts

6250693

afc163 reviewed Jul 29, 2020

View reviewed changes

fix: fix the dependency library place

bd7867a

afc163 merged commit e2aedcb into antvis:master Jul 29, 2020

pr-triage bot added PR: merged and removed PR: unreviewed labels Jul 29, 2020

afc163 mentioned this pull request Jul 29, 2020

playground 支持一下 typescript 和智能提示 #184

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support the monaco editor on example #195

feat: support the monaco editor on example #195

NewByVector commented Jul 21, 2020 •

edited

Loading

tests-checker bot left a comment

afc163 commented Jul 21, 2020 •

edited

Loading

NewByVector commented Jul 22, 2020

afc163 commented Jul 22, 2020

afc163 commented Jul 22, 2020

NewByVector commented Jul 22, 2020

afc163 commented Jul 22, 2020 •

edited

Loading

afc163 Jul 22, 2020

NewByVector commented Jul 22, 2020

afc163 commented Jul 23, 2020

afc163 commented Jul 23, 2020

NewByVector commented Jul 23, 2020

afc163 Jul 27, 2020

NewByVector Jul 29, 2020

afc163 Jul 29, 2020

afc163 Jul 29, 2020

afc163 commented Jul 29, 2020

NewByVector commented Jul 29, 2020

afc163 commented Jul 29, 2020

feat: support the monaco editor on example #195

feat: support the monaco editor on example #195

Conversation

NewByVector commented Jul 21, 2020 • edited Loading

tests-checker bot left a comment

Choose a reason for hiding this comment

afc163 commented Jul 21, 2020 • edited Loading

NewByVector commented Jul 22, 2020

afc163 commented Jul 22, 2020

afc163 commented Jul 22, 2020

NewByVector commented Jul 22, 2020

afc163 commented Jul 22, 2020 • edited Loading

afc163 Jul 22, 2020

Choose a reason for hiding this comment

NewByVector commented Jul 22, 2020

afc163 commented Jul 23, 2020

afc163 commented Jul 23, 2020

NewByVector commented Jul 23, 2020

afc163 Jul 27, 2020

Choose a reason for hiding this comment

NewByVector Jul 29, 2020

Choose a reason for hiding this comment

afc163 Jul 29, 2020

Choose a reason for hiding this comment

afc163 Jul 29, 2020

Choose a reason for hiding this comment

afc163 commented Jul 29, 2020

NewByVector commented Jul 29, 2020

afc163 commented Jul 29, 2020

NewByVector commented Jul 21, 2020 •

edited

Loading

afc163 commented Jul 21, 2020 •

edited

Loading

afc163 commented Jul 22, 2020 •

edited

Loading