[fix] Urlencode when passing filenames to sqlite3 (launchbadge#2655)

anupj · Oct 17, 2023 · b85b723 · b85b723
1 parent b16fbeb
commit b85b723
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/sqlx-sqlite/Cargo.toml b/sqlx-sqlite/Cargo.toml
@@ -43,6 +43,7 @@ tracing = { version = "0.1.37", features = ["log"] }
 
 serde = { version = "1.0.145", features = ["derive"], optional = true }
 regex = { version = "1.5.5", optional = true }
+urlencoding = "2.1.3"
 
 [dependencies.libsqlite3-sys]
 version = "0.26.0"

diff --git a/sqlx-sqlite/src/connection/establish.rs b/sqlx-sqlite/src/connection/establish.rs
@@ -100,7 +100,11 @@ impl EstablishParams {
         }
 
         if !query_params.is_empty() {
-            filename = format!("file:{}?{}", filename, query_params.join("&"));
+            filename = format!(
+                "file:{}?{}",
+                urlencoding::encode(&filename),
+                query_params.join("&")
+            );
             flags |= libsqlite3_sys::SQLITE_OPEN_URI;
         }