Merge pull request #213 from ghost/dev-allow-chat-while-challenged

Do not hide the `Chat` label while challenged.

modules/tbs/data/objects/user_online_entry.cfg

@@ -46,7 +46,29 @@
 					selected_index: -1,
 					zorder: zorder+10,
 					_font_size: lib.gui.py(14),
-					items: if(has_challenged, ['Accept', 'Decline'], ['Challenge'] + if(info.status != 'idle', ['Watch'], []) + ['Chat']),
+					items: if (
+						has_challenged,
+							['Accept', 'Decline'],
+						// else
+							//   TODO Consider making 'playing vs ai' local to `tbs`.
+							// Right now this is using a bit of `citadel` knowledge,
+							// reverting the abstraction `tbs` stands for.
+							['Challenge'] +
+								if (
+									info.status != 'idle'
+											and (observing_allowed_for_1vsAI or info.status != 'playing vs ai'),
+										['Watch'],
+									// else
+										[]
+								)
+					) + ['Chat']
+					where observing_allowed_for_1vsAI = developer_mode
+					where developer_mode = false
+						//   The `tictactoe` module will use this.
+						or MODULE_OPTIONS.devtools is null
+						//   The `citadel` module will use this.
+						or MODULE_OPTIONS.devtools is bool and MODULE_OPTIONS.devtools
+					,
 					click_handler: me._select_option,
 					grouping: info.id + '_user_info',
 				}, [