Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tried to make the engine retain the user selected resolution #416

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

UbuntuJackson
Copy link
Contributor

I changed 3 files and created preference_data.hpp. You should be weary of my lack of knowledge about how Frogatto treats it's virtual gamescreen sizes. Basically I added an if statement that separates presence and absence of a preferences.cfg. If the file exists, the autoSelectResolution function is not called, because why should the resolution be set automatically when user defined settings exist? Please notify me if my changes require further explanation.
Also here's a video showing off the changes.
https://youtu.be/Wueo7ppIjr0

@DDR0
Copy link
Contributor

DDR0 commented Jan 22, 2025

why should the resolution be set automatically when user defined settings exist?

Sometimes, when playing on a laptop, the laptop can be docked or undocked. The maximum screen resolution may change then. However... we probably just want a check for that when we load, and if we're trying to load a resolution larger than the combined current monitors attached... we fall back to the auto-resize option. However, this is kinda complex and hard to test for me, so I have no qualms about accepting this patch as-is. 🙂

@DDR0 DDR0 self-assigned this Jan 22, 2025
@DDR0 DDR0 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into anura-engine:trunk with commit 64ff944 Jan 22, 2025
76 checks passed
@Rotonen
Copy link
Contributor

Rotonen commented Jan 22, 2025

For potential downstream testing: screen geometries can also change on some tablet-like devices at runtime. (Turn tablet 90 degrees or open it up to double the screen. There are displays which extend at runtime via a rollup mechanism now too.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants