Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use same comment. Also don't pick removed files for delta validation #30

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

anuraag016
Copy link
Owner

Adds feature requested #27
Fixes bug raised #29

@anuraag016 anuraag016 changed the title Feature: Use same comment, don't pick removed files for delta validation Feature: Use same comment. Also don't pick removed files for delta validation Oct 18, 2021
@therynamo
Copy link

So would the messageToPost need to have the sha from the commit in it in order to see that reflected in the comment?

Some times it is valuable - especially if you push multiple commits in succession - to see which commit the comment is actually reflecting on. I think it is fine to put this on the user if we don't want any more application code to be developed here. That being said - would also be really nice to have the sha on that comment by default.

Though - you are the maintainer - so I leave that up to you :)

@therynamo
Copy link

Any updates on the trails of this? 😄

@anuraag016 anuraag016 merged commit 48136c0 into master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants