Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js #2571

Closed
wants to merge 2 commits into from
Closed

Update index.js #2571

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2023

No description provided.

@vercel
Copy link

vercel bot commented Mar 5, 2023

@Loftyvirus is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Mar 5, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: Theme JSON file could not be parsed: PR diff is not a valid theme JSON object.

@github-actions github-actions bot added the invalid The bug/issue caused by minor mistakes. label Mar 5, 2023
Copy link
Collaborator

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: PR diff is not a valid theme JSON object.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: PR diff is not a valid theme JSON object.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ lofty_blue

Result: ✔️ All themes are valid.

Details

Lofty_blue theme preview

title_color: #00eeff | icon_color: #00eeff | text_color: #00eeff | bg_color: #000000 | border_color: #000000

Preview Link

@github-actions github-actions bot removed the invalid The bug/issue caused by minor mistakes. label Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (ed18914) 97.29% compared to head (c6349ca) 97.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2571   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          24       24           
  Lines        4215     4222    +7     
  Branches      384      384           
=======================================
+ Hits         4101     4108    +7     
  Misses        112      112           
  Partials        2        2           
Impacted Files Coverage Δ
themes/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Zo-Bro-23
Copy link
Collaborator

Too similar to existing themes.

@Zo-Bro-23 Zo-Bro-23 closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants