fix: Make WakaTime card compatible with new API #2707

rickstaa · 2023-05-08T07:05:49Z

This commit makes sure that the WakaTime card works with the new WakaTime API. See #2698 for more information.

Note
Will be merged when I have one review of somebody that does use the WakaTime card.

This commit makes sure that the WakaTime card works with the new WakaTime API. See #2698 for more information.

vercel · 2023-05-08T07:05:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
github-readme-stats	✅ Ready (Inspect)	Visit Preview	May 9, 2023 1:40pm

codecov · 2023-05-08T07:08:46Z

Codecov Report

Patch coverage: 89.58% and project coverage change: -0.05 ⚠️

Comparison is base (688f4e4) 97.35% compared to head (d93c4d1) 97.30%.

❗ Current head d93c4d1 differs from pull request most recent head eb86029. Consider uploading reports for the commit eb86029 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2707      +/-   ##
==========================================
- Coverage   97.35%   97.30%   -0.05%     
==========================================
  Files          24       24              
  Lines        4310     4348      +38     
  Branches      393      402       +9     
==========================================
+ Hits         4196     4231      +35     
- Misses        112      115       +3     
  Partials        2        2

Impacted Files	Coverage Δ
src/fetchers/wakatime-fetcher.js	`76.47% <62.50%> (-2.95%)`	⬇️
src/cards/wakatime-card.js	`99.48% <90.90%> (-0.52%)`	⬇️
src/common/utils.js	`100.00% <100.00%> (ø)`
src/translations.js	`99.74% <100.00%> (+0.01%)`	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/fetchers/wakatime-fetcher.js

src/translations.js

src/fetchers/wakatime-fetcher.js

src/cards/wakatime-card.js

src/fetchers/wakatime-fetcher.js

tests/fetchWakatime.test.js

Co-authored-by: Hakula Chen <i@hakula.xyz>

JiveOff · 2023-05-09T18:42:19Z

Can confirm this PR fixes the issue I've been having with my card under my Wakapi instance.

rickstaa · 2023-05-09T18:54:15Z

Can confirm this MR fixes the issue I've been having with my card under my Wakapi instance.

@JiveOff thanks for the confirmation!

* fix: Make WakaTime card compatible with new API This commit makes sure that the WakaTime card works with the new WakaTime API. See anuraghazra#2698 for more information. * fix: fix chinese simplified translations * fix: improve WakaTime range order * test: fix WakaTime tests * refactor: remove WakaTime range loop * refactor: remove redundant WakaTime call * test: fix e2e tests Co-authored-by: Hakula Chen <i@hakula.xyz> --------- Co-authored-by: Hakula Chen <i@hakula.xyz>

muety · 2024-12-08T22:00:20Z

Any chances we can add the range query param back in? At least from Wakapi's perspective, I'd find it super convenient if a user could customize the time range displayed by their readme card without restricting their publicly accessible time range (via API) in general.

For example, a user might want to use the stats endpoint in some custom script or for displaying badges with a maximum time range of last_year, but at the same time have the card display only the past week (i.e. last_7_days). I'd find it cool to decouple this and allow to configure the card content independently from the underlying (generic) API endpoint.

fix: Make WakaTime card compatible with new API

6b8e06b

This commit makes sure that the WakaTime card works with the new WakaTime API. See #2698 for more information.

github-actions bot added card-i18n Card text translations. documentation Improvements or additions to documentation. labels May 8, 2023

vercel bot deployed to Preview May 8, 2023 07:06 View deployment

rickstaa mentioned this pull request May 8, 2023

Waka time card broken range parameter broken #2698

Closed

rickstaa requested a review from Zo-Bro-23 May 8, 2023 07:07

This was referenced May 8, 2023

wakatime card stopped working suddenly #2671

Closed

Can`t find wakaTime data #1112

Closed

rickstaa linked an issue May 8, 2023 that may be closed by this pull request

Waka time card broken range parameter broken #2698

Closed

rickstaa requested a review from anuraghazra May 8, 2023 07:30

hakula139 suggested changes May 8, 2023

View reviewed changes

src/fetchers/wakatime-fetcher.js Outdated Show resolved Hide resolved

src/translations.js Outdated Show resolved Hide resolved

vercel bot deployed to Preview May 8, 2023 19:40 View deployment

fix: fix chinese simplified translations

7ea55d0

vercel bot deployed to Preview May 8, 2023 19:45 View deployment

rickstaa added 2 commits May 8, 2023 21:45

fix: improve WakaTime range order

d80d766

test: fix WakaTime tests

65fa81f

vercel bot deployed to Preview May 8, 2023 19:47 View deployment

rickstaa requested a review from hakula139 May 8, 2023 19:48

alanhamlett reviewed May 9, 2023

View reviewed changes

src/fetchers/wakatime-fetcher.js Outdated Show resolved Hide resolved

hakula139 suggested changes May 9, 2023

View reviewed changes

src/cards/wakatime-card.js Show resolved Hide resolved

rickstaa closed this May 9, 2023

rickstaa reopened this May 9, 2023

refactor: remove WakaTime range loop

510dc18

rickstaa force-pushed the update_waka_to_new_api branch from 98fcc65 to 510dc18 Compare May 9, 2023 12:50

rickstaa requested a review from hakula139 May 9, 2023 12:50

vercel bot deployed to Preview May 9, 2023 12:50 View deployment

rickstaa requested a review from alanhamlett May 9, 2023 12:50

hakula139 suggested changes May 9, 2023

View reviewed changes

src/fetchers/wakatime-fetcher.js Outdated Show resolved Hide resolved

hakula139 suggested changes May 9, 2023

View reviewed changes

tests/fetchWakatime.test.js Show resolved Hide resolved

refactor: remove redundant WakaTime call

d93c4d1

vercel bot deployed to Preview May 9, 2023 13:35 View deployment

vercel bot deployed to Preview May 9, 2023 13:39 View deployment

test: fix e2e tests

eb86029

Co-authored-by: Hakula Chen <i@hakula.xyz>

rickstaa force-pushed the update_waka_to_new_api branch from 1db35b1 to eb86029 Compare May 9, 2023 13:40

rickstaa requested a review from hakula139 May 9, 2023 13:40

vercel bot deployed to Preview May 9, 2023 13:40 View deployment

hakula139 approved these changes May 9, 2023

View reviewed changes

qwerty541 mentioned this pull request May 13, 2023

Wakatime card can't find account #2720

Closed

qwerty541 mentioned this pull request May 27, 2023

Something went wrong! Wakatime user not found #2754

Closed

This was referenced May 29, 2023

Wakatime user not found #2757

Closed

wakatime stats image not finding user #2763

Closed

Zo-Bro-23 approved these changes Jun 2, 2023

View reviewed changes

Zo-Bro-23 merged commit c301289 into master Jun 2, 2023

rickstaa deleted the update_waka_to_new_api branch June 2, 2023 09:11

muety mentioned this pull request Jul 28, 2023

Infer stats endpoint default range from user settings muety/wakapi#508

Closed

commit-lint bot mentioned this pull request Aug 16, 2023

[pull] master from anuraghazra:master Crushoverride007/readme-stats#2

Open

muety mentioned this pull request Dec 8, 2024

Incorrect Title for Embedded GitHub Status Card muety/wakapi#715

Closed

muety mentioned this pull request Dec 10, 2024

Reintroduce range parameter for WakaTime card #4064

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Make WakaTime card compatible with new API #2707

fix: Make WakaTime card compatible with new API #2707

rickstaa commented May 8, 2023 •

edited

Loading

vercel bot commented May 8, 2023 •

edited

Loading

codecov bot commented May 8, 2023 •

edited

Loading

JiveOff commented May 9, 2023 •

edited

Loading

rickstaa commented May 9, 2023

muety commented Dec 8, 2024 •

edited

Loading

fix: Make WakaTime card compatible with new API #2707

fix: Make WakaTime card compatible with new API #2707

Conversation

rickstaa commented May 8, 2023 • edited Loading

vercel bot commented May 8, 2023 • edited Loading

codecov bot commented May 8, 2023 • edited Loading

Codecov Report

JiveOff commented May 9, 2023 • edited Loading

rickstaa commented May 9, 2023

muety commented Dec 8, 2024 • edited Loading

rickstaa commented May 8, 2023 •

edited

Loading

vercel bot commented May 8, 2023 •

edited

Loading

codecov bot commented May 8, 2023 •

edited

Loading

JiveOff commented May 9, 2023 •

edited

Loading

muety commented Dec 8, 2024 •

edited

Loading