Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats card: show started and answered discussions stats #2849

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Stats card: show started and answered discussions stats #2849

merged 4 commits into from
Jun 19, 2023

Conversation

qwerty541
Copy link
Collaborator

@qwerty541 qwerty541 commented Jun 17, 2023 •
edited
Loading

изображение

@qwerty541 qwerty541 requested a review from rickstaa June 17, 2023 22:43
@codecov
Copy link

codecov bot commented Jun 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (03b0ba0) 97.67% compared to head (319c52d) 97.71%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2849      +/-   ##
==========================================
+ Coverage   97.67%   97.71%   +0.04%     
==========================================
  Files          24       24              
  Lines        4982     5074      +92     
  Branches      449      451       +2     
==========================================
+ Hits         4866     4958      +92     
  Misses        115      115              
  Partials        1        1
Impacted Files Coverage Δ
src/cards/stats-card.js 100.00% <100.00%> (ø)
src/common/icons.js 100.00% <100.00%> (ø)
src/fetchers/stats-fetcher.js 93.01% <100.00%> (+0.26%) ⬆️
src/translations.js 99.84% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel
Copy link

vercel bot commented Jun 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-stats ✅ Ready (Inspect) Visit Preview Jun 19, 2023 2:59am

@github-actions github-actions bot added card-i18n Card text translations. documentation Improvements or additions to documentation. stats-card Feature, Enhancement, Fixes related to stats the stats card. labels Jun 17, 2023
rickstaa
rickstaa requested changes Jun 18, 2023
View reviewed changes
Copy link
Collaborator

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwerty541 I think you made a perfect pull request. The only thing I would do is to split discussions into discussions and answered_discussion. I, for example, don't want to show the total discussions on the card but would like to show the number of answered discussions now that GitHub removed that from their UI.

qwerty541
qwerty541 commented Jun 19, 2023
View reviewed changes
Copy link
Collaborator Author

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwerty541 I think you made a perfect pull request. The only thing I would do is to split discussions into discussions and answered_discussion. I, for example, don't want to show the total discussions on the card but would like to show the number of answered discussions now that GitHub removed that from their UI.

@rickstaa You are right that the started and answered discussions should be splitted. I have update the code, please check it.

@qwerty541 qwerty541 requested a review from rickstaa June 19, 2023 03:04
@rickstaa rickstaa merged commit 92518e3 into master Jun 19, 2023
@rickstaa rickstaa deleted the stats_card_show_discussions branch June 19, 2023 03:52
HackingGate pushed a commit to HackingGate/github-readme-stats that referenced this pull request Jun 25, 2023
@qwerty541 @HackingGate
Stats card: show started and answered discussions stats (anuraghazra#…
cd56253 
…2849)

* Stats card: show started and answered discussions stats

* trans

* dev
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
@qwerty541 @devantler
Stats card: show started and answered discussions stats (anuraghazra#…
40fe8ac 
…2849)

* Stats card: show started and answered discussions stats

* trans

* dev
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
@qwerty541 @setdebarr
Stats card: show started and answered discussions stats (anuraghazra#…
a56b79b 
…2849)

* Stats card: show started and answered discussions stats

* trans

* dev
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this pull request Nov 6, 2024
@qwerty541 @jacobbexten
Stats card: show started and answered discussions stats (anuraghazra#…
464c47a 
…2849)

* Stats card: show started and answered discussions stats

* trans

* dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickstaa rickstaa rickstaa approved these changes

Assignees
No one assigned
Labels
card-i18n Card text translations. documentation Improvements or additions to documentation. stats-card Feature, Enhancement, Fixes related to stats the stats card.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwerty541 @rickstaa