Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a less restrictive ocaml/dune constraint #98

Closed
anuragsoni opened this issue Mar 22, 2020 · 0 comments · Fixed by #100
Closed

Use a less restrictive ocaml/dune constraint #98

anuragsoni opened this issue Mar 22, 2020 · 0 comments · Fixed by #100
Labels
good first issue Good for newcomers

Comments

@anuragsoni
Copy link
Owner

With the removal of the the HTTP method handling we no longer use features that were specific to OCaml 4.06 (we were using Map.update before that). Ubuntu LTS still ships with OCaml 4.05 and there might be value in supporting versions at least as old as that. The code in the current condition should already compile with 4.05 so its just a matter of updating the version constraint in the opam file.

If a version older than 4.05 is needed, we'd need to replace the String.index_opt with something that works in older versions.

On a similar note we aren't using anything that truly needs a feature added only in dune 2. The autogenerated opam files are nice to have, but we don't really anticipate needing to touch the opam file too much so just maintaining that hand-written opam file can work. This would allow dropping the version constraint on dune.

@anuragsoni anuragsoni added the good first issue Good for newcomers label Mar 22, 2020
anuragsoni added a commit that referenced this issue Mar 23, 2020
anuragsoni added a commit that referenced this issue Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant