Skip to content
This repository has been archived by the owner on Feb 25, 2019. It is now read-only.

Validate that jwks and jwks_uri are not used together #212

Merged
merged 1 commit into from
Sep 2, 2015

Conversation

adalinesimonian
Copy link
Member

Fixes #98

This involved customizing the validation function for the Client model because there is no logic in Modinha or Revalidator that supports cross-property validation rules.

cc @christiansmith

@christiansmith
Copy link
Member

@vsimonian that's a really good point. I think we should either contribute to revalidator to add multi-property validation, add some layer into Modinha that adds this behavior by wrapping revalidator, or write our own JSON Schema validator entirely within Modinha that incorporates this and other features we've bolted on.

@adalinesimonian
Copy link
Member Author

We might consider looking at lx-valid - they've extended revalidator with useful utilities we may take advantage of, all while maintaining backwards-compatibility. They also seem to be in active development, whereas Revalidator itself seems a bit stale.

@christiansmith
Copy link
Member

This PR looks good. Merging. Thanks.

christiansmith added a commit that referenced this pull request Sep 2, 2015
…ks_uri

Validate that jwks and jwks_uri are not used together
@christiansmith christiansmith merged commit 8b61322 into master Sep 2, 2015
@adalinesimonian adalinesimonian deleted the vsimonian-validate-jwks-jwks_uri branch September 2, 2015 01:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants