-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In freeze, Git tag gets replaced with potentially unusable SHA #33
Comments
We are facing the same issues at Savoir-faire Linux. The bit of code looks like:
Hope it helps |
@foutoucour thanks for feedback, but I think it's unrelated. Indeed the commands you're showing actually circumvent the refusal to freeze if local modifications of any kind are found, which is a feature deliberately introduced from the ground up: it protects the user against releasing something that may behave differently than the local copy (a local modification actually leading to a significative behaviour difference is uncommon, but each occurrence has a high cost in terms of debugging time). In the past, it has happened that local modifications could have been introduced by the recipe itself (setup.py) in which case of course nothing becomes releasable, in particular not on bots, and that's been treated as a bug in itself. Regards, |
The new is_local_fixed_revision() will be used by freeze-to() to decide whether a revision specification must be replaced by a frozen one or not.
@sandreanybox would you please be so kind to try the current a.r.openerp-1.9 branch, namely the [8ae5bb6] I just pushed. They should work better for you. |
This is a special case of issue #2 which qualifies as a bug (infrequent)
Actually, even tags used in the buildout to freeze get replaced by their SHA (which at least cannot be garbage collected).
Now, SHAs can be fetched only if they are reachable from the HEAD of remote repo (typically master), which means that currently tags on feature branches cannot be used at all in the freeze/extract part of the process. This is not a projection, it just happened on a real project at Anybox.
The text was updated successfully, but these errors were encountered: