forked from cloudfoundry/stratos
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to help with building as packages and fix devkit and package info #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use centos 7 as default base image * don't remove packages that aren't there * set imagePullPolicy to IfNotPresent * adjust docker org and tag * make builds work with centos 7, also revise build script to include param for architecture * adjust image list for centos 7
* Fix install of swag Go now uses `go install` instead of `go get` to install packages to the local machine * replace docs module appropriately * Configure dependabot Introduce a basic dependabot.yaml to check for updates both in the project root for npm and in the backend directory (src/jetstream) for go * Include website and electron projects in dependabot
* Delete grufty go.sum, gut go.mod entirely and refresh dependencies * add back some dependencies needed for tests to run; update return values of methods using go-sqlmock to use pointers
* Fix backend unit tests - Ensure int value is formatted as such - This was causing the backend unit tests to fail, possibly by dependency change * Replace ioutil usage and decapitalize error strings * Change receiver to be a pointer in order for assignment to persist If the receiver is not pointer, the struct is copied and the assignment `r.sent = true` has no effect because r will be discarded after the function returns. --------- Co-authored-by: Richard Cox <ricox@suse.com>
In this case, `prjMetadata.root` is an untyped JSON result (that is, it can be object, array, number, etc.), but FS.copySync needs to take a string; do an explicit cast here to make TypeScript happy. Signed-off-by: Mark Yen <mark.yen@suse.com> Co-authored-by: Mark Yen <mark.yen@suse.com>
Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com>
* Migrate to goose fork * Code quality improvements from go-staticcheck * Migrate migrations to github.com/pressly/goose --------- Co-authored-by: Ivan Kapelyukhin <ikapelyukhin@suse.com>
* Delete grufty go.sum, gut go.mod entirely and refresh dependencies * add back some dependencies needed for tests to run; update return values of methods using go-sqlmock to use pointers * Update module structure * Small update of functions/imports to get latest version * Adjust to pointers for newer version of sqlmock * Remove ioutil, add new logic to actually get expiry claim from jwt * Move api into its own module * change all dependent code besides mock implementaions * Change mock implementations manually as no gomock command is documented * Moved and regenerated mock implementations This was donw with the commands `mockgen -source=api/auth.go > api/mock/mock_auth.go as well as `mockgen -source=repository/apikeys/apikeys.go > repository/apikeys/mock/mock_apikeys.go` after installing https://github.com/golang/mock with `go install github.com/golang/mock/mockgen@v1.6.0`. This tool however is archived and should be replaced with a fork.
* Add action to build base images/push to ghcr.io * Upgrade go to 1.20.7 * set all docker related env variables to anynines/ghcr.io/centos7
* Add Helm support for local repos in desktop mode * Join errors instead of returning just the second error * Implement all methods required by interface * Properly quote struct tags * Bubble up errors, don't just drop them * no longer use deprecated ioutil package, replace with os and io * Don't capitalize error messages * Remove formatting directives from string, parameters should be appended instead * Fix the CVEs in the jetstream backend (#12) * Delete grufty go.sum, gut go.mod entirely and refresh dependencies * add back some dependencies needed for tests to run; update return values of methods using go-sqlmock to use pointers * Fix backend unit tests (also code quality improvements) (#15) * Fix backend unit tests - Ensure int value is formatted as such - This was causing the backend unit tests to fail, possibly by dependency change * Replace ioutil usage and decapitalize error strings * Change receiver to be a pointer in order for assignment to persist If the receiver is not pointer, the struct is copied and the assignment `r.sent = true` has no effect because r will be discarded after the function returns. --------- Co-authored-by: Richard Cox <ricox@suse.com> * Theme Builder: Cast types (#16) In this case, `prjMetadata.root` is an untyped JSON result (that is, it can be object, array, number, etc.), but FS.copySync needs to take a string; do an explicit cast here to make TypeScript happy. Signed-off-by: Mark Yen <mark.yen@suse.com> Co-authored-by: Mark Yen <mark.yen@suse.com> * Update required disk space (#17) Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com> * Migrate to github.com/pressly/goose (#18) * Migrate to goose fork * Code quality improvements from go-staticcheck * Migrate migrations to github.com/pressly/goose --------- Co-authored-by: Ivan Kapelyukhin <ikapelyukhin@suse.com> * Move repository/interfaces to its own submodule: api (#19) * Delete grufty go.sum, gut go.mod entirely and refresh dependencies * add back some dependencies needed for tests to run; update return values of methods using go-sqlmock to use pointers * Update module structure * Small update of functions/imports to get latest version * Adjust to pointers for newer version of sqlmock * Remove ioutil, add new logic to actually get expiry claim from jwt * Move api into its own module * change all dependent code besides mock implementaions * Change mock implementations manually as no gomock command is documented * Moved and regenerated mock implementations This was donw with the commands `mockgen -source=api/auth.go > api/mock/mock_auth.go as well as `mockgen -source=repository/apikeys/apikeys.go > repository/apikeys/mock/mock_apikeys.go` after installing https://github.com/golang/mock with `go install github.com/golang/mock/mockgen@v1.6.0`. This tool however is archived and should be replaced with a fork. * Build and push base images on push to develop (#11) * Add action to build base images/push to ghcr.io * Upgrade go to 1.20.7 * set all docker related env variables to anynines/ghcr.io/centos7 * Add Helm support for local repos in desktop mode * Add github.com/pressly/goose --------- Signed-off-by: Mark Yen <mark.yen@suse.com> Co-authored-by: Neil MacDougall <neil.macdougall@suse.com> Co-authored-by: Richard Cox <ricox@suse.com> Co-authored-by: Mark Yen <mark.yen@suse.com> Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com> Co-authored-by: Ivan Kapelyukhin <ikapelyukhin@suse.com>
* Add github.com/pressly/goose * Tidy up go.mod and go.sum
Once again fell victim to the insane interface for opening PRs on a forked repo... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a manual application of cloudfoundry#4529
It adds a script to build the frontend packages, and fixes the devkit as well as the package info in some of the packages.