Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riesz s-Energy returns different outputs for same random seed #638

Closed
LucasAlegre opened this issue Aug 20, 2024 · 7 comments
Closed

Riesz s-Energy returns different outputs for same random seed #638

LucasAlegre opened this issue Aug 20, 2024 · 7 comments
Assignees

Comments

@LucasAlegre
Copy link

If you start two different Python processes and run:

get_reference_directions("energy", 4, 32, seed=42)

I get different outputs each time. I believe there is something wrong with how the random seed is set.

@blankjul blankjul self-assigned this Aug 25, 2024
@blankjul
Copy link
Collaborator

very interesting. I quickly looked into it and yes I can reproduce it that even though the random seed is provided the results don't match.

However, the np.random.seed(seed) method seems to be called in all runs.

Need to look a little more into this and will let you know.

@blankjul
Copy link
Collaborator

I think the commit above fixes this now. Can you please check?

@LucasAlegre
Copy link
Author

I cannot install it from source because I'm using python 3.8 and pymoo now requires python>=3.9 :/

@blankjul
Copy link
Collaborator

blankjul commented Nov 5, 2024

I will close this issue for now. You can use conda do update your environment if needed. Please reopen the issue if you find the current version does not resolve it.

@blankjul blankjul closed this as completed Nov 5, 2024
@LucasAlegre
Copy link
Author

Do you have an estimate of when a new release will be on pypi with this fix? Thanks!

@blankjul
Copy link
Collaborator

I usually try to create a release 2-3 times a year. Depending on the number of commits.

Was the fix successful with the current dev version?

@LucasAlegre
Copy link
Author

When following the instructions in the README to install it from source, it installs version 0.6.0.1 and then the fix does not seem to have worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants