GO-2828: add debug diagnostics for spaces and connections #314
+206
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
…debug-diagnostics-for-spaces-and-connections
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
mcrakhman
reviewed
Nov 8, 2024
net/pool/pool_test.go
Outdated
| @@ -240,16 +357,31 @@ func (d *dialerMock) Name() (name string) { | |||
| return "net.peerservice" | |||
| } | |||
|
|
|||
| func newTestPeer(id string) *testPeer { | |||
| func newTestPeer(id string, created time.Time, subConnections int, version uint32) *testPeer { | |||
There was a problem hiding this comment.
make another constructor for testPeer with all that stuff, don't change other tests
| return &Stat{ | ||
| PeerId: p.id, | ||
| SubConnections: subConnectionsCount, | ||
| Created: p.created, |
There was a problem hiding this comment.
add a field called AliveTimeSecs which will tell how many seconds it is alive
There was a problem hiding this comment.
Just write pls p.Lock(), defer p.Unlock() and then return &Stat{...}
There was a problem hiding this comment.
How do you propose to calculate AliveTimeSecs, because don't see such field in peer? 🧐
…debug-diagnostics-for-spaces-and-connections
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/anytype/issue/GO-2828/add-debug-diagnostics-for-spaces-and-connections