DROID-2815 Editor | Tech | Increase timeout limit when loading images…

… for image block (#1912)
anyproto · Dec 12, 2024 · d711e84 · d711e84
1 parent 1511bab
commit d711e84
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/core-ui/src/main/java/com/anytypeio/anytype/core_ui/features/editor/holders/media/Picture.kt b/core-ui/src/main/java/com/anytypeio/anytype/core_ui/features/editor/holders/media/Picture.kt
@@ -43,7 +43,7 @@ class Picture(val binding: ItemBlockPictureBinding) : Media(binding.root), Decor
             isFirstResource: Boolean
         ): Boolean {
             error.visible()
-            Timber.w(e, "Error while loading picture")
+            Timber.w(e, "Error while loading picture with url: $model")
             return false
         }
 
@@ -65,6 +65,7 @@ class Picture(val binding: ItemBlockPictureBinding) : Media(binding.root), Decor
             .with(image)
             .load(item.url)
             .listener(listener)
+            .timeout(LOADING_TIMEOUT_IN_MILLIS)
             .into(image)
     }
 
@@ -88,4 +89,8 @@ class Picture(val binding: ItemBlockPictureBinding) : Media(binding.root), Decor
             res = itemView.resources
         )
     }
+
+    companion object {
+        const val LOADING_TIMEOUT_IN_MILLIS = 30000
+    }
 }
diff --git a/presentation/src/main/java/com/anytypeio/anytype/presentation/mapper/MapperExtension.kt b/presentation/src/main/java/com/anytypeio/anytype/presentation/mapper/MapperExtension.kt
@@ -62,8 +62,8 @@ fun Block.Content.File.toPictureView(
         val url = urlBuilder.getUrlForFileContent(this)
         val targetId = this.targetObjectId
         val struct = details.details[targetId]?.map
-        if (url != null && targetId != null && !struct.isNullOrEmpty()) {
-            val targetObject = ObjectWrapper.File(struct)
+        if (url != null && targetId != null) {
+            val targetObject = ObjectWrapper.File(struct.orEmpty())
             BlockView.Media.Picture(
                 id = blockId,
                 targetObjectId = targetId,