-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Droid 3185 file layout hide file block #1947
base: release/0-34-0
Are you sure you want to change the base?
Droid 3185 file layout hide file block #1947
Conversation
…hide-file-block # Conflicts: # presentation/src/main/java/com/anytypeio/anytype/presentation/editor/render/DefaultBlockViewRenderer.kt
@@ -530,6 +542,12 @@ class BlockAdapter( | |||
ItemBlockMediaErrorBinding.inflate(inflater, parent, false) | |||
) | |||
} | |||
HOLDER_OPEN_FILE -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOLDER_BUTTON_OPEN_FILE
HOLDER_OPEN_FILE -> { | ||
OpenFile(ItemBlockOpenFileBinding.inflate(inflater, parent, false)) | ||
} | ||
HOLDER_OPEN_IMAGE -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem
icon.setIcon(item.icon) | ||
} | ||
|
||
override fun applyTextColor(item: BlockView.Title) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add comment: "// Do nothing"
@@ -1268,6 +1296,28 @@ sealed class BlockView : ViewType { | |||
override fun getViewType(): Int = HOLDER_FEATURED_RELATION | |||
} | |||
|
|||
sealed class OpenFile( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ButtonOpenFile
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?