Sort entries alphabetically to ensure deterministic ordering #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the order of entries is partially random when multiple entries have the same score.
This is an issue when trying to open applications such as LibreOffice, which comes with multiple desktop entries (LibreOffice, LibreOffice Writer, LibreOffice Draw, LibreOffice Impress...). The "LibreOffice" entry may be completely inaccessible when just typing "LibreOffice" since the list is by default truncated to 5 entries and the entry may be preceded by more than 5 other entries.
The change in this commit sorts the entries alphabetically when they have the same score, ensuring that shorter entries are always listed first. Therefore, when typing "LibreOffice," the list always begins with "LibreOffice," "LibreOffice Base," "LibreOffice Calc"...