Remove custom custom_llm_gpu resource specification for text-embeddings template
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2024 11:01
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
|
can we remove this resource from the application? Not sure what the purpose of this is here if it's assigned to every node type |
Signed-off-by: Scott Lee <sjl@anyscale.com>
scottjlee
changed the title
text-embeddings templatetext-embeddings template
added 2 commits
February 25, 2024 11:47
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
akshay-anyscale
approved these changes
Feb 26, 2024
scottjlee
changed the title
text-embeddings templatecustom_llm_gpu resource specification for text-embeddings template
anmscale
pushed a commit
that referenced
this pull request
Jun 22, 2024
Remove custom `custom_llm_gpu` resource specification for `text-embeddings` template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#67 created the
text-embeddingsworkspace template with a bad config involvingcustom_llm_gpuwhich prevents satisfying the resource requirement. This PR fixes the issue by removing the unnecessary configuration, since autoscaling works across any of the GPU worker types by default.