fix: example should use remote link and alb controller version fixed to 1.11.0 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
brent-anyscale
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Thanks for working on this. I think that updating the module references for the Anyscale AWS modules is a good change, but for the sub-modules within this one, the changes should remain as relative paths. We can evaluate changing this in the future, but without duplicating every example as a "test" we eliminate the ability to test changes. Using the relative path is standard practice for examples with public modules.
examples/aws/eks-public/main.tf
Outdated
| source = "../../../modules/anyscale-k8s-helm" | ||
| #checkov:skip=CKV_TF_1: Example code should use the latest version of the module | ||
| #checkov:skip=CKV_TF_2: Example code should use the latest version of the module | ||
| source = "github.com/anyscale/terraform-kubernetes-anyscale-foundation-modules//modules/anyscale-k8s-helm" |
There was a problem hiding this comment.
Doing it this way will limit the capabilities for using the examples for internal testing. If doing this, we will need to also create testing examples.
There was a problem hiding this comment.
OK will change it back
hongchaodeng
force-pushed
the
hdeng/fix-minor
branch
from
c33db1e to
533a837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
appVersionPull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?
Other information