upd: Existing GKE Example #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: new file: README.md new file: main.tf new file: outputs.tf new file: variables.tf new file: versions.tf
Changes to be committed: modified: README.md
Changes to be committed: modified: README.md
Add IAM support, Helm Chart for Ingress, etc. Additional changes to support sleep time for Helm Chart to be installed for ingress controller. Added Job sample test. Changes to be committed: modified: .pre-commit-config.yaml modified: examples/aws/eks-private/README.md modified: examples/aws/eks-private/main.tf modified: examples/aws/eks-private/outputs.tf modified: examples/aws/eks-public/README.md modified: examples/aws/eks-public/main.tf modified: examples/aws/eks-public/outputs.tf modified: examples/gcp/gke-existing_cluster/README.md new file: examples/gcp/gke-existing_cluster/data.tf modified: examples/gcp/gke-existing_cluster/main.tf modified: examples/gcp/gke-existing_cluster/outputs.tf modified: examples/gcp/gke-existing_cluster/variables.tf modified: examples/gcp/gke-existing_cluster/versions.tf modified: modules/anyscale-k8s-helm/README.md deleted: modules/anyscale-k8s-helm/data.tf modified: modules/anyscale-k8s-helm/helm-autoscaler.tf modified: modules/anyscale-k8s-helm/helm-ingress.tf modified: modules/anyscale-k8s-helm/variables.tf new file: test/anyscale-job/main-job-test.py new file: test/test_job.py
github-actions
bot
added
documentation
Changes to be committed: modified: examples/gcp/gke-existing_cluster/README.md
hongchaodeng
approved these changes
Oct 15, 2024
| @@ -51,20 +48,30 @@ variable "existing_vpc_name" { | |||
| type = string | |||
| } | |||
|
|
|||
| variable "existing_subnet_name" { | |||
| description = "The name of the existing Subnet" | |||
| variable "existing_vpc_id" { | |||
There was a problem hiding this comment.
We don't need both existing_vpc_name and existing_vpc_id. Can use one to query the other.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Additional updates for Helm Chart Ingress sleeps for availability, Job Test python, GCP Storage Bucket permissions, and updates to latest CLI commands.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?
Breaking changes for example. This will recreate some of the resources.